mirror of
https://github.com/servo/servo.git
synced 2025-08-06 22:15:33 +01:00
webdriver: Get the window position as well as the size when resolving "Get Window Rect" (#37812)
1. Rename `GetWindowSize` to `GetWindowRect` 2. Return the WindowRect in device pixels correctly. Previously, it returns `(0, 0, ScreenWidth, ScreenHeight)` which is a static value. 3. Add `fn window_rect` to `WindowPortsMethods`. Implement it for both Headless Window and Headed Window. Testing: Tested manually with powershell script. Result is now dynamic and reflects the truth. Fixes: Task 1 & 2 of https://github.com/servo/servo/issues/37804 --------- Signed-off-by: Euclid Ye <yezhizhenjiakang@gmail.com>
This commit is contained in:
parent
95d9d3a412
commit
94f35ba998
7 changed files with 35 additions and 19 deletions
|
@ -4534,7 +4534,7 @@ where
|
|||
let is_open = self.browsing_contexts.contains_key(&browsing_context_id);
|
||||
let _ = response_sender.send(is_open);
|
||||
},
|
||||
WebDriverCommandMsg::GetWindowSize(..) => {
|
||||
WebDriverCommandMsg::GetWindowRect(..) => {
|
||||
unreachable!("This command should be send directly to the embedder.");
|
||||
},
|
||||
WebDriverCommandMsg::GetViewportSize(..) => {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue