Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

Add RTCPeerConnection::AddIceCandidate

Browse source
This commit is contained in:
Manish Goregaokar 2019-01-26 20:22:39 -08:00
parent 841dd1eb4b
commit 9521c3d5a4
2 changed files with 36 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

35
components/script/dom/rtcpeerconnection.rs
View file

@ -3,6 +3,7 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
use crate::dom::bindings::cell::DomRefCell;
use crate::dom::bindings::codegen::Bindings::RTCIceCandidateBinding::RTCIceCandidateInit;
use crate::dom::bindings::codegen::Bindings::RTCPeerConnectionBinding::RTCConfiguration;
use crate::dom::bindings::codegen::Bindings::RTCPeerConnectionBinding::{
self, RTCPeerConnectionMethods,
@ -13,9 +14,11 @@ use crate::dom::bindings::refcounted::Trusted;
use crate::dom::bindings::reflector::reflect_dom_object;
use crate::dom::bindings::reflector::DomObject;
use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::error::Error;
use crate::dom::event::{Event, EventBubbles, EventCancelable};
use crate::dom::eventtarget::EventTarget;
use crate::dom::globalscope::GlobalScope;
use crate::dom::promise::Promise;
use crate::dom::rtcicecandidate::RTCIceCandidate;
use crate::dom::rtcpeerconnectioniceevent::RTCPeerConnectionIceEvent;
use crate::dom::window::Window;
@ -29,6 +32,7 @@ use servo_media::webrtc::{IceCandidate, WebRtcController, WebRtcSignaller};
use servo_media::ServoMedia;
use std::cell::Cell;
use std::rc::Rc;
#[dom_struct]
pub struct RTCPeerConnection {
@ -164,4 +168,35 @@ impl RTCPeerConnectionMethods for RTCPeerConnection {
GetOnnegotiationneeded,
SetOnnegotiationneeded
);
/// https://www.w3.org/TR/webrtc/#dom-rtcpeerconnection-addicecandidate
fn AddIceCandidate(&self, candidate: &RTCIceCandidateInit) -> Rc<Promise> {
let p = Promise::new(&self.global());
if candidate.sdpMid.is_none() && candidate.sdpMLineIndex.is_none() {
p.reject_error(Error::Type(format!(
"one of sdpMid and sdpMLineIndex must be set"
)));
return p;
}
// XXXManishearth add support for sdpMid
if candidate.sdpMLineIndex.is_none() {
p.reject_error(Error::Type(format!(
"servo only supports sdpMLineIndex right now"
)));
return p;
}
// XXXManishearth this should be enqueued
// https://www.w3.org/TR/webrtc/#enqueue-an-operation
self.controller.borrow_mut().as_ref().unwrap().add_ice_candidate(IceCandidate {
sdp_mline_index: candidate.sdpMLineIndex.unwrap() as u32,
candidate: candidate.candidate.to_string()
});
// XXXManishearth add_ice_candidate should have a callback
p.resolve_native(&());
p
}
}

2
components/script/dom/webidls/RTCPeerConnection.webidl
View file

@ -17,7 +17,7 @@ interface RTCPeerConnection : EventTarget {
// readonly attribute RTCSessionDescription? remoteDescription;
// readonly attribute RTCSessionDescription? currentRemoteDescription;
// readonly attribute RTCSessionDescription? pendingRemoteDescription;
// Promise<void> addIceCandidate(RTCIceCandidateInit candidate);
Promise<void> addIceCandidate(optional RTCIceCandidateInit candidate);
// readonly attribute RTCSignalingState signalingState;
// readonly attribute RTCIceGatheringState iceGatheringState;
// readonly attribute RTCIceConnectionState iceConnectionState;