Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-30 10:40:27 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix false positive in unrooted_must_root lint.

Browse source 
Encountered in #8725.
This commit is contained in:
Eli Friedman 2015-11-28 21:29:08 -08:00
parent 2d164f2beb
commit 962c06e9da
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/plugins/lints/unrooted_must_root.rs
View file

@ -4,6 +4,7 @@
use rustc::front::map as ast_map; use rustc::front::map as ast_map;
use rustc::lint::{LateContext, LintPass, LintArray, LateLintPass, LintContext}; use rustc::lint::{LateContext, LintPass, LintArray, LateLintPass, LintContext};
use rustc::middle::pat_util::pat_is_binding;
use rustc::middle::ty; use rustc::middle::ty;
use rustc_front::hir; use rustc_front::hir;
use rustc_front::intravisit as visit; use rustc_front::intravisit as visit;
@ -206,11 +207,13 @@ impl<'a, 'b: 'a, 'tcx: 'a+'b> visit::Visitor<'a> for FnDefVisitor<'a, 'b, 'tcx>
let cx = self.cx; let cx = self.cx;
if let hir::PatIdent(hir::BindByValue(_), _, _) = pat.node { if let hir::PatIdent(hir::BindByValue(_), _, _) = pat.node {
let ty = cx.tcx.pat_ty(pat); if pat_is_binding(&cx.tcx.def_map.borrow(), pat) {
if is_unrooted_ty(cx, ty, self.in_new_function) { let ty = cx.tcx.pat_ty(pat);
cx.span_lint(UNROOTED_MUST_ROOT, if is_unrooted_ty(cx, ty, self.in_new_function) {
pat.span, cx.span_lint(UNROOTED_MUST_ROOT,
&format!("Expression of type {:?} must be rooted", ty)) pat.span,
&format!("Expression of type {:?} must be rooted", ty))
}
} }
} }