Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

dom: should change media element's currentSrc to children source element's src in resource selection algorithm. (#36408)

Browse source 
Set the `htmlmediaelement`'s `currenSrc` in
resource-selection-algorithm.
Change the `htmlsourceelement`'s src and srcset to USVString type.

According to
[Spec](https://html.spec.whatwg.org/multipage/media.html#concept-media-load-algorithm),
Step 9.3 for mode is children, should set the `currentSrc` to `src` of
children `htmlsourceelement`.
Also, In the `htmlsourceelement` [interface
definition](https://html.spec.whatwg.org/multipage/embedded-content.html#the-source-element),
the `src` and `srcset` attribute should be type `USVString`.

Testing: More WPT tests related to resource selection algorithm are
passing.
Fix: Some spec fix

[Try](https://github.com/rayguo17/servo/actions/runs/14347535616)
cc @xiaochengh

Signed-off-by: rayguo17 <rayguo17@gmail.com>
This commit is contained in:
TIN TUN AUNG 2025-04-11 14:32:34 +08:00 • committed by GitHub
parent c8ecb57d97
commit 972ca77ce1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 22 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/wpt/meta/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-insert-before.html.ini vendored
View file

@ -1,4 +0,0 @@
[resource-selection-candidate-insert-before.html]
[inserting another source before the candidate]
expected: FAIL

19
tests/wpt/meta/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html.ini vendored
View file

@ -1,19 +0,0 @@
[currentSrc.html]
[audio.currentSrc after adding source element with src attribute " "]
expected: FAIL
[video.currentSrc after adding source element with src attribute "."]
expected: FAIL
[video.currentSrc after adding source element with src attribute "data:,"]
expected: FAIL
[audio.currentSrc after adding source element with src attribute "."]
expected: FAIL
[audio.currentSrc after adding source element with src attribute "data:,"]
expected: FAIL
[video.currentSrc after adding source element with src attribute " "]
expected: FAIL