From 6a4173fbeb9b4e85fbea154af3bd3529f14805b8 Mon Sep 17 00:00:00 2001 From: Jonathan Guillotte-Blouin Date: Mon, 15 May 2017 14:23:30 -0700 Subject: [PATCH 1/8] Bug 1270740 - remove requestAutocomplete reference --- components/script/dom/webidls/HTMLFormElement.webidl | 2 -- 1 file changed, 2 deletions(-) diff --git a/components/script/dom/webidls/HTMLFormElement.webidl b/components/script/dom/webidls/HTMLFormElement.webidl index fba10d25509..c9232cc6d6c 100644 --- a/components/script/dom/webidls/HTMLFormElement.webidl +++ b/components/script/dom/webidls/HTMLFormElement.webidl @@ -24,6 +24,4 @@ interface HTMLFormElement : HTMLElement { void reset(); //boolean checkValidity(); //boolean reportValidity(); - - //void requestAutocomplete(); }; From 181c71fbb8fe0f88484f7dabf544a9b43b1c406f Mon Sep 17 00:00:00 2001 From: Matt Brubeck Date: Mon, 15 May 2017 17:13:52 -0700 Subject: [PATCH 2/8] Fix markdown warning in parse_product doc comment --- components/style/values/specified/calc.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/style/values/specified/calc.rs b/components/style/values/specified/calc.rs index 4f49df256e7..892acea87b4 100644 --- a/components/style/values/specified/calc.rs +++ b/components/style/values/specified/calc.rs @@ -233,9 +233,9 @@ impl CalcNode { /// /// This should parse correctly: /// - /// * `2` - /// * `2 * 2` - /// * `2 * 2 + 2` (but will leave the `+ 2` unparsed). + /// * `2` + /// * `2 * 2` + /// * `2 * 2 + 2` (but will leave the `+ 2` unparsed). /// fn parse_product( context: &ParserContext, From 73ecdfcc6e9da0fa9dbdfc9a2608d9c222cc9767 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Thu, 18 May 2017 16:16:07 +0200 Subject: [PATCH 3/8] Update to cargo 0.20.0-nightly (2233f51 2017-05-17) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit … which includes https://github.com/rust-lang/cargo/pull/4065 Compile time from `mach clean` on 4 cores / 8 threads with incremental compilation improved by 4%. --- cargo-commit-hash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cargo-commit-hash b/cargo-commit-hash index ab91ab90564..78b19407e07 100644 --- a/cargo-commit-hash +++ b/cargo-commit-hash @@ -1 +1 @@ -994e552f1f9515c84ec2ed66012bf3bd1684c206 \ No newline at end of file +2233f515b1e8281841ceaed802f74fe2f9e54701 From f8532b14e9cf756a65e300e0f168342530b414f6 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Fri, 19 May 2017 11:29:06 +0200 Subject: [PATCH 4/8] Update dbus crate to fix a warning. https://github.com/diwic/dbus-rs/issues/79 --- Cargo.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index bdbdd94df12..8f498ecf7fa 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -262,7 +262,7 @@ name = "blurz" version = "0.2.2" source = "registry+https://github.com/rust-lang/crates.io-index" dependencies = [ - "dbus 0.5.2 (registry+https://github.com/rust-lang/crates.io-index)", + "dbus 0.5.3 (registry+https://github.com/rust-lang/crates.io-index)", "rustc-serialize 0.3.24 (registry+https://github.com/rust-lang/crates.io-index)", ] @@ -568,7 +568,7 @@ dependencies = [ [[package]] name = "dbus" -version = "0.5.2" +version = "0.5.3" source = "registry+https://github.com/rust-lang/crates.io-index" dependencies = [ "libc 0.2.22 (registry+https://github.com/rust-lang/crates.io-index)", @@ -3475,7 +3475,7 @@ dependencies = [ "checksum cssparser 0.13.5 (registry+https://github.com/rust-lang/crates.io-index)" = "88dc7bd2a41b9c6c66456ac709d9efead1deb390d2c252c59e0ddfff9cdf0c94" "checksum cssparser-macros 0.3.0 (registry+https://github.com/rust-lang/crates.io-index)" = "079adec4af52bb5275eadd004292028c79eb3c5f5b4ee8086a36d4197032f6df" "checksum dbghelp-sys 0.2.0 (registry+https://github.com/rust-lang/crates.io-index)" = "97590ba53bcb8ac28279161ca943a924d1fd4a8fb3fa63302591647c4fc5b850" -"checksum dbus 0.5.2 (registry+https://github.com/rust-lang/crates.io-index)" = "47f881971824401c27bc1ff9f641d54ac66e0f409631806fa7be8cad8e6be450" +"checksum dbus 0.5.3 (registry+https://github.com/rust-lang/crates.io-index)" = "4aee01fb76ada3e5e7ca642ea6664ebf7308a810739ca2aca44909a1191ac254" "checksum debug_unreachable 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)" = "9a032eac705ca39214d169f83e3d3da290af06d8d1d344d1baad2fd002dca4b3" "checksum deflate 0.7.5 (registry+https://github.com/rust-lang/crates.io-index)" = "ebb02aaf4b775afc96684b8402510a338086974e38570a1f65bea8c202eb77a7" "checksum deque 0.3.1 (registry+https://github.com/rust-lang/crates.io-index)" = "1614659040e711785ed8ea24219140654da1729f3ec8a47a9719d041112fe7bf" From 7f1794bb5cfaf2c49cd2f841cf9d6defe182a483 Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Tue, 16 May 2017 14:19:38 -0700 Subject: [PATCH 5/8] Use boolean instead of float to avoid nightly warning --- ports/geckolib/glue.rs | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/ports/geckolib/glue.rs b/ports/geckolib/glue.rs index f7aca89a524..d4608655d94 100644 --- a/ports/geckolib/glue.rs +++ b/ports/geckolib/glue.rs @@ -2197,16 +2197,18 @@ fn append_computed_property_value(keyframe: *mut structs::Keyframe, } } +enum Offset { + Zero, + One +} + fn fill_in_missing_keyframe_values(all_properties: &[TransitionProperty], timing_function: nsTimingFunctionBorrowed, style: &ComputedValues, properties_set_at_offset: &LonghandIdSet, - offset: f32, + offset: Offset, keyframes: RawGeckoKeyframeListBorrowedMut, shared_lock: &SharedRwLock) { - debug_assert!(offset == 0. || offset == 1., - "offset should be 0. or 1."); - let needs_filling = all_properties.iter().any(|ref property| { !properties_set_at_offset.has_transition_property_bit(property) }); @@ -2217,13 +2219,12 @@ fn fill_in_missing_keyframe_values(all_properties: &[TransitionProperty], } let keyframe = match offset { - 0. => unsafe { + Offset::Zero => unsafe { Gecko_GetOrCreateInitialKeyframe(keyframes, timing_function) }, - 1. => unsafe { + Offset::One => unsafe { Gecko_GetOrCreateFinalKeyframe(keyframes, timing_function) }, - _ => unreachable!("offset should be 0. or 1."), }; // Append properties that have not been set at this offset. @@ -2352,7 +2353,7 @@ pub extern "C" fn Servo_StyleSet_GetKeyframesForName(raw_data: RawServoStyleSetB inherited_timing_function, style, &properties_set_at_start, - 0., + Offset::Zero, keyframes, &global_style_data.shared_lock); } @@ -2361,7 +2362,7 @@ pub extern "C" fn Servo_StyleSet_GetKeyframesForName(raw_data: RawServoStyleSetB inherited_timing_function, style, &properties_set_at_end, - 1., + Offset::One, keyframes, &global_style_data.shared_lock); } From fa857f56d228ea974e0eba4c6e5b256db6b077a9 Mon Sep 17 00:00:00 2001 From: Akshay Chiwhane Date: Sun, 21 May 2017 11:50:47 -0400 Subject: [PATCH 6/8] Fix style issues as per #16980 --- components/style/properties/longhand/box.mako.rs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/components/style/properties/longhand/box.mako.rs b/components/style/properties/longhand/box.mako.rs index fe9aa583a2b..ef477fdeb86 100644 --- a/components/style/properties/longhand/box.mako.rs +++ b/components/style/properties/longhand/box.mako.rs @@ -1596,28 +1596,28 @@ ${helpers.predefined_type("scroll-snap-coordinate", }, "rotate" => { try!(input.parse_nested_block(|input| { - let theta = try!(specified::Angle::parse_with_unitless(context,input)); + let theta = try!(specified::Angle::parse_with_unitless(context, input)); result.push(SpecifiedOperation::Rotate(theta)); Ok(()) })) }, "rotatex" => { try!(input.parse_nested_block(|input| { - let theta = try!(specified::Angle::parse_with_unitless(context,input)); + let theta = try!(specified::Angle::parse_with_unitless(context, input)); result.push(SpecifiedOperation::RotateX(theta)); Ok(()) })) }, "rotatey" => { try!(input.parse_nested_block(|input| { - let theta = try!(specified::Angle::parse_with_unitless(context,input)); + let theta = try!(specified::Angle::parse_with_unitless(context, input)); result.push(SpecifiedOperation::RotateY(theta)); Ok(()) })) }, "rotatez" => { try!(input.parse_nested_block(|input| { - let theta = try!(specified::Angle::parse_with_unitless(context,input)); + let theta = try!(specified::Angle::parse_with_unitless(context, input)); result.push(SpecifiedOperation::RotateZ(theta)); Ok(()) })) @@ -1630,7 +1630,7 @@ ${helpers.predefined_type("scroll-snap-coordinate", try!(input.expect_comma()); let az = try!(specified::parse_number(context, input)); try!(input.expect_comma()); - let theta = try!(specified::Angle::parse_with_unitless(context,input)); + let theta = try!(specified::Angle::parse_with_unitless(context, input)); // TODO(gw): Check the axis can be normalized!! result.push(SpecifiedOperation::Rotate3D(ax, ay, az, theta)); Ok(()) @@ -1650,14 +1650,14 @@ ${helpers.predefined_type("scroll-snap-coordinate", }, "skewx" => { try!(input.parse_nested_block(|input| { - let theta_x = try!(specified::Angle::parse_with_unitless(context,input)); + let theta_x = try!(specified::Angle::parse_with_unitless(context, input)); result.push(SpecifiedOperation::SkewX(theta_x)); Ok(()) })) }, "skewy" => { try!(input.parse_nested_block(|input| { - let theta_y = try!(specified::Angle::parse_with_unitless(context,input)); + let theta_y = try!(specified::Angle::parse_with_unitless(context, input)); result.push(SpecifiedOperation::SkewY(theta_y)); Ok(()) })) From 3565600f989b9022461fd1fb4dcf0abdafcf1131 Mon Sep 17 00:00:00 2001 From: Simon Sapin Date: Mon, 22 May 2017 14:37:33 +0200 Subject: [PATCH 7/8] Selectors 0.18 is published, bump to 0.19 --- Cargo.lock | 18 +++++++++--------- components/selectors/Cargo.toml | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 4fb540e2fe2..6399fa7f2f5 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -971,7 +971,7 @@ dependencies = [ "log 0.3.7 (registry+https://github.com/rust-lang/crates.io-index)", "nsstring_vendor 0.1.0", "parking_lot 0.3.8 (registry+https://github.com/rust-lang/crates.io-index)", - "selectors 0.18.0", + "selectors 0.19.0", "style 0.0.1", "style_traits 0.0.1", "stylo_tests 0.0.1", @@ -1397,7 +1397,7 @@ dependencies = [ "rayon 0.7.0 (registry+https://github.com/rust-lang/crates.io-index)", "script_layout_interface 0.0.1", "script_traits 0.0.1", - "selectors 0.18.0", + "selectors 0.19.0", "serde 0.9.15 (registry+https://github.com/rust-lang/crates.io-index)", "serde_derive 0.9.15 (registry+https://github.com/rust-lang/crates.io-index)", "serde_json 0.9.10 (registry+https://github.com/rust-lang/crates.io-index)", @@ -1445,7 +1445,7 @@ dependencies = [ "script 0.0.1", "script_layout_interface 0.0.1", "script_traits 0.0.1", - "selectors 0.18.0", + "selectors 0.19.0", "serde_derive 0.9.15 (registry+https://github.com/rust-lang/crates.io-index)", "serde_json 0.9.10 (registry+https://github.com/rust-lang/crates.io-index)", "servo_config 0.0.1", @@ -2368,7 +2368,7 @@ dependencies = [ "script_layout_interface 0.0.1", "script_plugins 0.0.1", "script_traits 0.0.1", - "selectors 0.18.0", + "selectors 0.19.0", "serde 0.9.15 (registry+https://github.com/rust-lang/crates.io-index)", "serde_json 0.9.10 (registry+https://github.com/rust-lang/crates.io-index)", "servo_atoms 0.0.1", @@ -2412,7 +2412,7 @@ dependencies = [ "profile_traits 0.0.1", "range 0.0.1", "script_traits 0.0.1", - "selectors 0.18.0", + "selectors 0.19.0", "servo_url 0.0.1", "style 0.0.1", "webrender_traits 0.39.0 (git+https://github.com/servo/webrender)", @@ -2465,7 +2465,7 @@ dependencies = [ [[package]] name = "selectors" -version = "0.18.0" +version = "0.19.0" dependencies = [ "bitflags 0.7.0 (registry+https://github.com/rust-lang/crates.io-index)", "cssparser 0.13.5 (registry+https://github.com/rust-lang/crates.io-index)", @@ -2860,7 +2860,7 @@ dependencies = [ "precomputed-hash 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)", "rayon 0.7.0 (registry+https://github.com/rust-lang/crates.io-index)", "regex 0.2.1 (registry+https://github.com/rust-lang/crates.io-index)", - "selectors 0.18.0", + "selectors 0.19.0", "serde 0.9.15 (registry+https://github.com/rust-lang/crates.io-index)", "serde_derive 0.9.15 (registry+https://github.com/rust-lang/crates.io-index)", "servo_atoms 0.0.1", @@ -2896,7 +2896,7 @@ dependencies = [ "parking_lot 0.3.8 (registry+https://github.com/rust-lang/crates.io-index)", "rayon 0.7.0 (registry+https://github.com/rust-lang/crates.io-index)", "rustc-serialize 0.3.24 (registry+https://github.com/rust-lang/crates.io-index)", - "selectors 0.18.0", + "selectors 0.19.0", "servo_atoms 0.0.1", "servo_config 0.0.1", "servo_url 0.0.1", @@ -2929,7 +2929,7 @@ dependencies = [ "geckoservo 0.0.1", "libc 0.2.22 (registry+https://github.com/rust-lang/crates.io-index)", "log 0.3.7 (registry+https://github.com/rust-lang/crates.io-index)", - "selectors 0.18.0", + "selectors 0.19.0", "size_of_test 0.0.1", "style 0.0.1", "style_traits 0.0.1", diff --git a/components/selectors/Cargo.toml b/components/selectors/Cargo.toml index 4ca9a240c67..f0c48ad4f8d 100644 --- a/components/selectors/Cargo.toml +++ b/components/selectors/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "selectors" -version = "0.18.0" # Not yet published +version = "0.19.0" # Not yet published authors = ["Simon Sapin ", "Alan Jeffrey "] documentation = "https://docs.rs/selectors/" From bb45b667a9b7d20d5f06c3aed9d3ed0245346e0a Mon Sep 17 00:00:00 2001 From: Anthony Ramine Date: Tue, 23 May 2017 15:55:03 +0200 Subject: [PATCH 8/8] Don't lint commit messages anymore This lint cannot cope with rollup merges and didn't do its job correctly anyway --- python/tidy/servo_tidy/tidy.py | 32 +------------------------------- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git a/python/tidy/servo_tidy/tidy.py b/python/tidy/servo_tidy/tidy.py index 610ac20d624..8d7e6c07b72 100644 --- a/python/tidy/servo_tidy/tidy.py +++ b/python/tidy/servo_tidy/tidy.py @@ -1072,34 +1072,6 @@ def run_lint_scripts(only_changed_files=False, progress=True, stylo=False): yield error -def check_commits(path='.'): - """ Checks if the test is being run under Travis CI environment - This is necessary since, after travis clones the branch for a PR, it merges - the branch against master, creating a merge commit. Hence, as a workaround, - we have to check if the second last merge commit is done by the author of - the pull request. - """ - is_travis = os.environ.get('TRAVIS') == 'true' - number_commits = '-n2' if is_travis else '-n1' - - """Gets all commits since the last merge.""" - args = ['git', 'log', number_commits, '--merges', '--format=%H:%an'] - # last_merge stores both the commit hash and the author name of the last merge in the output - last_merge_hash, last_merge_author = subprocess.check_output(args, cwd=path).strip().splitlines()[-1].split(':') - args = ['git', 'log', '{}..HEAD'.format(last_merge_hash), '--format=%s'] - commits = subprocess.check_output(args, cwd=path).lower().splitlines() - - for commit in commits: - # .split() to only match entire words - if 'wip' in commit.split(): - yield (':', ':', 'no commits should contain WIP') - - if last_merge_author != 'bors-servo': - yield (':', ':', 'no merge commits allowed, please rebase your commits over the upstream master branch') - - raise StopIteration - - def scan(only_changed_files=False, progress=True, stylo=False): # check config file for errors config_errors = check_config_file(CONFIG_FILE_PATH) @@ -1115,11 +1087,9 @@ def scan(only_changed_files=False, progress=True, stylo=False): dep_license_errors = check_dep_license_errors(get_dep_toml_files(only_changed_files), progress) # other lint checks lint_errors = run_lint_scripts(only_changed_files, progress, stylo=stylo) - # check commits for WIP - commit_errors = [] if stylo else check_commits() # chain all the iterators errors = itertools.chain(config_errors, directory_errors, lint_errors, - file_errors, dep_license_errors, commit_errors) + file_errors, dep_license_errors) error = None for error in errors: