Implement crypto.randomUUID() (#33158)

Signed-off-by: webbeef <me@webbeef.org>

components/script/dom/crypto.rs

@@ -7,12 +7,14 @@ use js::jsapi::{JSObject, Type};
 use js::rust::CustomAutoRooterGuard;
 use js::typedarray::{ArrayBufferView, ArrayBufferViewU8, TypedArray};
 use servo_rand::{RngCore, ServoRng};
+use uuid::Uuid;
 
 use crate::dom::bindings::cell::DomRefCell;
 use crate::dom::bindings::codegen::Bindings::CryptoBinding::CryptoMethods;
 use crate::dom::bindings::error::{Error, Fallible};
 use crate::dom::bindings::reflector::{reflect_dom_object, Reflector};
 use crate::dom::bindings::root::DomRoot;
+use crate::dom::bindings::str::USVString;
 use crate::dom::globalscope::GlobalScope;
 use crate::script_runtime::JSContext;
 
@@ -40,7 +42,7 @@ impl Crypto {
 
 impl CryptoMethods for Crypto {
     #[allow(unsafe_code)]
-    // https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#Crypto-method-getRandomValues
+    // https://w3c.github.io/webcrypto/#Crypto-method-getRandomValues
     fn GetRandomValues(
         &self,
         _cx: JSContext,
@@ -61,6 +63,15 @@ impl CryptoMethods for Crypto {
                 .map_err(|_| Error::JSFailed)
         }
     }
+
+    // https://w3c.github.io/webcrypto/#Crypto-method-randomUUID
+    fn RandomUUID(&self) -> USVString {
+        let uuid = Uuid::new_v4();
+        uuid.hyphenated()
+            .encode_lower(&mut Uuid::encode_buffer())
+            .to_owned()
+            .into()
+    }
 }
 
 fn is_integer_buffer(array_type: Type) -> bool {

components/script/dom/webidls/Crypto.webidl

@@ -20,4 +20,8 @@ interface Crypto {
   //readonly attribute SubtleCrypto subtle;
   [Throws]
   ArrayBufferView getRandomValues(ArrayBufferView array);
+
+  [SecureContext]
+  // UTF8String is not observably different from USVString
+  USVString randomUUID();
 };

tests/wpt/meta-legacy-layout/WebCryptoAPI/idlharness.https.any.js.ini

@@ -206,12 +206,6 @@
   [SubtleCrypto interface: calling generateKey(AlgorithmIdentifier, boolean, sequence<KeyUsage>) on crypto.subtle with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Crypto interface: operation randomUUID()]
-    expected: FAIL
-
-  [Crypto interface: crypto must inherit property "randomUUID()" with the proper type]
-    expected: FAIL
-
   [SubtleCrypto interface: operation deriveBits(AlgorithmIdentifier, CryptoKey, optional unsigned long?)]
     expected: FAIL
 
@@ -430,12 +424,6 @@
   [SubtleCrypto interface: calling generateKey(AlgorithmIdentifier, boolean, sequence<KeyUsage>) on crypto.subtle with too few arguments must throw TypeError]
     expected: FAIL
 
-  [Crypto interface: operation randomUUID()]
-    expected: FAIL
-
-  [Crypto interface: crypto must inherit property "randomUUID()" with the proper type]
-    expected: FAIL
-
   [SubtleCrypto interface: operation deriveBits(AlgorithmIdentifier, CryptoKey, optional unsigned long?)]
     expected: FAIL
 

tests/wpt/meta-legacy-layout/WebCryptoAPI/randomUUID.https.any.js.ini

@@ -1,20 +0,0 @@
-[randomUUID.https.any.html]
-  [namespace format]
-    expected: FAIL
-
-  [version set]
-    expected: FAIL
-
-  [variant set]
-    expected: FAIL
-
-
-[randomUUID.https.any.worker.html]
-  [namespace format]
-    expected: FAIL
-
-  [version set]
-    expected: FAIL
-
-  [variant set]
-    expected: FAIL

tests/wpt/meta/WebCryptoAPI/idlharness.https.any.js.ini

@@ -2,15 +2,9 @@
   [Crypto interface: attribute subtle]
     expected: FAIL
 
-  [Crypto interface: operation randomUUID()]
-    expected: FAIL
-
   [Crypto interface: crypto must inherit property "subtle" with the proper type]
     expected: FAIL
 
-  [Crypto interface: crypto must inherit property "randomUUID()" with the proper type]
-    expected: FAIL
-
   [CryptoKey interface: existence and properties of interface object]
     expected: FAIL
 
@@ -187,15 +181,9 @@
   [Crypto interface: attribute subtle]
     expected: FAIL
 
-  [Crypto interface: operation randomUUID()]
-    expected: FAIL
-
   [Crypto interface: crypto must inherit property "subtle" with the proper type]
     expected: FAIL
 
-  [Crypto interface: crypto must inherit property "randomUUID()" with the proper type]
-    expected: FAIL
-
   [CryptoKey interface: existence and properties of interface object]
     expected: FAIL
 

tests/wpt/meta/WebCryptoAPI/randomUUID.https.any.js.ini

@@ -1,20 +0,0 @@
-[randomUUID.https.any.html]
-  [namespace format]
-    expected: FAIL
-
-  [version set]
-    expected: FAIL
-
-  [variant set]
-    expected: FAIL
-
-
-[randomUUID.https.any.worker.html]
-  [namespace format]
-    expected: FAIL
-
-  [version set]
-    expected: FAIL
-
-  [variant set]
-    expected: FAIL