Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implement 'background' IDL attribute on <body>

Browse source
This commit is contained in:
Corey Farwell 2016-01-02 14:02:28 -08:00
parent c0835ec336
commit 9a1fd472ab
4 changed files with 12 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

11
components/script/dom/htmlbodyelement.rs
View file

@ -84,6 +84,17 @@ impl HTMLBodyElementMethods for HTMLBodyElement {
fn SetOnstorage(&self, listener: Option<Rc<EventHandlerNonNull>>) { fn SetOnstorage(&self, listener: Option<Rc<EventHandlerNonNull>>) {
window_from_node(self).SetOnstorage(listener) window_from_node(self).SetOnstorage(listener)
} }
// https://html.spec.whatwg.org/multipage/#dom-body-background
make_getter!(Background, "background");
// https://html.spec.whatwg.org/multipage/#dom-body-background
fn SetBackground(&self, value: DOMString) {
let document = document_from_node(self);
let base = document.url();
*self.background.borrow_mut() = base.join(&value).ok();
self.upcast::<Element>().set_string_attribute(&atom!("background"), value);
}
} }
pub trait HTMLBodyElementLayoutHelpers { pub trait HTMLBodyElementLayoutHelpers {

2
components/script/dom/webidls/HTMLBodyElement.webidl
View file

@ -23,5 +23,5 @@ partial interface HTMLBodyElement {
//[TreatNullAs=EmptyString] attribute DOMString aLink; //[TreatNullAs=EmptyString] attribute DOMString aLink;
[TreatNullAs=EmptyString] attribute DOMString bgColor; [TreatNullAs=EmptyString] attribute DOMString bgColor;
// attribute DOMString background; attribute DOMString background;
}; };

6
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -2169,9 +2169,6 @@
[HTMLBodyElement interface: attribute aLink] [HTMLBodyElement interface: attribute aLink]
expected: FAIL expected: FAIL
[HTMLBodyElement interface: attribute background]
expected: FAIL
[HTMLBodyElement interface: attribute onafterprint] [HTMLBodyElement interface: attribute onafterprint]
expected: FAIL expected: FAIL
@ -2214,9 +2211,6 @@
[HTMLBodyElement interface: document.createElement("body") must inherit property "aLink" with the proper type (3)] [HTMLBodyElement interface: document.createElement("body") must inherit property "aLink" with the proper type (3)]
expected: FAIL expected: FAIL
[HTMLBodyElement interface: document.createElement("body") must inherit property "background" with the proper type (5)]
expected: FAIL
[HTMLBodyElement interface: document.createElement("body") must inherit property "onafterprint" with the proper type (6)] [HTMLBodyElement interface: document.createElement("body") must inherit property "onafterprint" with the proper type (6)]
expected: FAIL expected: FAIL

129
tests/wpt/metadata/html/dom/reflection-sections.html.ini
View file

@ -846,135 +846,6 @@
[body.aLink: IDL set to object "test-valueOf" followed by IDL get] [body.aLink: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL expected: FAIL
[body.background: typeof IDL attribute]
expected: FAIL
[body.background: IDL get with DOM attribute unset]
expected: FAIL
[body.background: setAttribute() to "" followed by IDL get]
expected: FAIL
[body.background: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by IDL get]
expected: FAIL
[body.background: setAttribute() to undefined followed by IDL get]
expected: FAIL
[body.background: setAttribute() to 7 followed by IDL get]
expected: FAIL
[body.background: setAttribute() to 1.5 followed by IDL get]
expected: FAIL
[body.background: setAttribute() to true followed by IDL get]
expected: FAIL
[body.background: setAttribute() to false followed by IDL get]
expected: FAIL
[body.background: setAttribute() to object "[object Object\]" followed by IDL get]
expected: FAIL
[body.background: setAttribute() to NaN followed by IDL get]
expected: FAIL
[body.background: setAttribute() to Infinity followed by IDL get]
expected: FAIL
[body.background: setAttribute() to -Infinity followed by IDL get]
expected: FAIL
[body.background: setAttribute() to "\\0" followed by IDL get]
expected: FAIL
[body.background: setAttribute() to null followed by IDL get]
expected: FAIL
[body.background: setAttribute() to object "test-toString" followed by IDL get]
expected: FAIL
[body.background: setAttribute() to object "test-valueOf" followed by IDL get]
expected: FAIL
[body.background: IDL set to "" followed by getAttribute()]
expected: FAIL
[body.background: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by getAttribute()]
expected: FAIL
[body.background: IDL set to undefined followed by getAttribute()]
expected: FAIL
[body.background: IDL set to undefined followed by IDL get]
expected: FAIL
[body.background: IDL set to 7 followed by getAttribute()]
expected: FAIL
[body.background: IDL set to 7 followed by IDL get]
expected: FAIL
[body.background: IDL set to 1.5 followed by getAttribute()]
expected: FAIL
[body.background: IDL set to 1.5 followed by IDL get]
expected: FAIL
[body.background: IDL set to true followed by getAttribute()]
expected: FAIL
[body.background: IDL set to true followed by IDL get]
expected: FAIL
[body.background: IDL set to false followed by getAttribute()]
expected: FAIL
[body.background: IDL set to false followed by IDL get]
expected: FAIL
[body.background: IDL set to object "[object Object\]" followed by getAttribute()]
expected: FAIL
[body.background: IDL set to object "[object Object\]" followed by IDL get]
expected: FAIL
[body.background: IDL set to NaN followed by getAttribute()]
expected: FAIL
[body.background: IDL set to NaN followed by IDL get]
expected: FAIL
[body.background: IDL set to Infinity followed by getAttribute()]
expected: FAIL
[body.background: IDL set to Infinity followed by IDL get]
expected: FAIL
[body.background: IDL set to -Infinity followed by getAttribute()]
expected: FAIL
[body.background: IDL set to -Infinity followed by IDL get]
expected: FAIL
[body.background: IDL set to "\\0" followed by getAttribute()]
expected: FAIL
[body.background: IDL set to null followed by getAttribute()]
expected: FAIL
[body.background: IDL set to null followed by IDL get]
expected: FAIL
[body.background: IDL set to object "test-toString" followed by getAttribute()]
expected: FAIL
[body.background: IDL set to object "test-toString" followed by IDL get]
expected: FAIL
[body.background: IDL set to object "test-valueOf" followed by IDL get]
expected: FAIL
[body.itemScope: typeof IDL attribute] [body.itemScope: typeof IDL attribute]
expected: FAIL expected: FAIL