Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-16 18:08:23 +01:00
Code Issues Projects Releases Packages Wiki Activity

Avoid crash in PlacementAmongFloats (#30235)

Browse source 
PlacementAmongFloats was assuming that there would always be a FloatBand
at a position smaller than or equal to the given ceiling, but this was
not the case for negative ceilings.

The reason is that the FloatContext initialized the FloatBandTree with
a band at 0, and another at +∞.

This patch changes the initial bands to −∞ and +∞. This seems more
consistent and matches the expectation of PlacementAmongFloats.
This commit is contained in:
Oriol Brufau 2023-08-29 20:40:05 +02:00 • committed by GitHub
parent 70f0088986
commit 9aa3f74878
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 109 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/wpt/meta/MANIFEST.json
View file

@ -61965,6 +61965,19 @@
{}
]
],
"floats-wrap-bfc-with-margin-010.html": [
"1cc9690602fd6b6beb383aef8a80e7ee8be926e3",
[
null,
[
[
"/css/CSS2/floats/floats-wrap-bfc-with-margin-010-ref.html",
"=="
]
],
{}
]
],
"floats-wrap-top-below-bfc-001l.xht": [
"17bec33eb143ce14f13c439e83f433c3fef74fdd",
[
@ -365676,6 +365689,10 @@
"ac45eb30bf43748284a1c7a19061f8df56fa5dca",
[]
],
"floats-wrap-bfc-with-margin-010-ref.html": [
"b29df933ebae5558f63d799907cbef138910dfd5",
[]
],
"floats-wrap-top-below-001l-notref.xht": [
"0953df73d203c1bb3e8d1dba0a3b7a2cde465e18",
[]