mirror of
https://github.com/servo/servo.git
synced 2025-08-05 13:40:08 +01:00
Invoke backup element queue via a microtask
This commit is contained in:
parent
4665991503
commit
9b587a4f2d
15 changed files with 252 additions and 7 deletions
|
@ -29,6 +29,8 @@ use js::conversions::ToJSValConvertible;
|
||||||
use js::jsapi::{Construct1, IsCallable, IsConstructor, HandleValueArray, HandleObject, MutableHandleValue};
|
use js::jsapi::{Construct1, IsCallable, IsConstructor, HandleValueArray, HandleObject, MutableHandleValue};
|
||||||
use js::jsapi::{Heap, JS_GetProperty, JSAutoCompartment, JSContext};
|
use js::jsapi::{Heap, JS_GetProperty, JSAutoCompartment, JSContext};
|
||||||
use js::jsval::{JSVal, NullValue, ObjectValue, UndefinedValue};
|
use js::jsval::{JSVal, NullValue, ObjectValue, UndefinedValue};
|
||||||
|
use microtask::Microtask;
|
||||||
|
use script_thread::ScriptThread;
|
||||||
use std::cell::Cell;
|
use std::cell::Cell;
|
||||||
use std::collections::{HashMap, VecDeque};
|
use std::collections::{HashMap, VecDeque};
|
||||||
use std::ops::Deref;
|
use std::ops::Deref;
|
||||||
|
@ -532,13 +534,7 @@ impl CustomElementReactionStack {
|
||||||
self.processing_backup_element_queue.set(BackupElementQueueFlag::Processing);
|
self.processing_backup_element_queue.set(BackupElementQueueFlag::Processing);
|
||||||
|
|
||||||
// Step 4
|
// Step 4
|
||||||
// TODO: Invoke Microtask
|
ScriptThread::enqueue_microtask(Microtask::CustomElementReaction);
|
||||||
|
|
||||||
// Step 4.1
|
|
||||||
self.backup_queue.invoke_reactions();
|
|
||||||
|
|
||||||
// Step 4.2
|
|
||||||
self.processing_backup_element_queue.set(BackupElementQueueFlag::NotProcessing);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/// https://html.spec.whatwg.org/multipage/#enqueue-a-custom-element-callback-reaction
|
/// https://html.spec.whatwg.org/multipage/#enqueue-a-custom-element-callback-reaction
|
||||||
|
@ -630,6 +626,7 @@ impl ElementQueue {
|
||||||
while let Some(element) = self.next_element() {
|
while let Some(element) = self.next_element() {
|
||||||
element.invoke_reactions()
|
element.invoke_reactions()
|
||||||
}
|
}
|
||||||
|
self.queue.borrow_mut().clear();
|
||||||
}
|
}
|
||||||
|
|
||||||
fn next_element(&self) -> Option<Root<Element>> {
|
fn next_element(&self) -> Option<Root<Element>> {
|
||||||
|
|
|
@ -15,6 +15,7 @@ use dom::htmlimageelement::ImageElementMicrotask;
|
||||||
use dom::htmlmediaelement::MediaElementMicrotask;
|
use dom::htmlmediaelement::MediaElementMicrotask;
|
||||||
use dom::mutationobserver::MutationObserver;
|
use dom::mutationobserver::MutationObserver;
|
||||||
use msg::constellation_msg::PipelineId;
|
use msg::constellation_msg::PipelineId;
|
||||||
|
use script_thread::ScriptThread;
|
||||||
use std::cell::Cell;
|
use std::cell::Cell;
|
||||||
use std::mem;
|
use std::mem;
|
||||||
use std::rc::Rc;
|
use std::rc::Rc;
|
||||||
|
@ -33,6 +34,7 @@ pub enum Microtask {
|
||||||
Promise(EnqueuedPromiseCallback),
|
Promise(EnqueuedPromiseCallback),
|
||||||
MediaElement(MediaElementMicrotask),
|
MediaElement(MediaElementMicrotask),
|
||||||
ImageElement(ImageElementMicrotask),
|
ImageElement(ImageElementMicrotask),
|
||||||
|
CustomElementReaction,
|
||||||
NotifyMutationObservers,
|
NotifyMutationObservers,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -87,6 +89,9 @@ impl MicrotaskQueue {
|
||||||
Microtask::ImageElement(ref task) => {
|
Microtask::ImageElement(ref task) => {
|
||||||
task.handler();
|
task.handler();
|
||||||
},
|
},
|
||||||
|
Microtask::CustomElementReaction => {
|
||||||
|
ScriptThread::invoke_backup_element_queue();
|
||||||
|
},
|
||||||
Microtask::NotifyMutationObservers => {
|
Microtask::NotifyMutationObservers => {
|
||||||
MutationObserver::notify_mutation_observers();
|
MutationObserver::notify_mutation_observers();
|
||||||
}
|
}
|
||||||
|
|
|
@ -755,6 +755,15 @@ impl ScriptThread {
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
pub fn invoke_backup_element_queue() {
|
||||||
|
SCRIPT_THREAD_ROOT.with(|root| {
|
||||||
|
if let Some(script_thread) = root.get() {
|
||||||
|
let script_thread = unsafe { &*script_thread };
|
||||||
|
script_thread.custom_element_reaction_stack.invoke_backup_element_queue();
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
/// Creates a new script thread.
|
/// Creates a new script thread.
|
||||||
pub fn new(state: InitialScriptState,
|
pub fn new(state: InitialScriptState,
|
||||||
port: Receiver<MainThreadScriptMsg>,
|
port: Receiver<MainThreadScriptMsg>,
|
||||||
|
|
|
@ -129,3 +129,48 @@
|
||||||
[Custom Elements: adoptedCallback]
|
[Custom Elements: adoptedCallback]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into the owner document must not enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into the document of the template elements must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Moving a custom element from the owner document into the document of the template elements must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into a new document must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Moving a custom element from the owner document into a new document must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into a cloned document must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Moving a custom element from the owner document into a cloned document must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into a document created by createHTMLDocument must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Moving a custom element from the owner document into a document created by createHTMLDocument must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into an HTML document created by createDocument must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Moving a custom element from the owner document into an HTML document created by createDocument must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into the document of an iframe must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Moving a custom element from the owner document into the document of an iframe must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into an HTML document fetched by XHR must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Moving a custom element from the owner document into an HTML document fetched by XHR must enqueue and invoke adoptedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -99,3 +99,27 @@
|
||||||
[Custom Elements: connectedCallback]
|
[Custom Elements: connectedCallback]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into the document must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into the document of the template elements must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into a new document must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into a cloned document must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into a document created by createHTMLDocument must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into an HTML document created by createDocument must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into the document of an iframe must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Inserting a custom element into an HTML document fetched by XHR must enqueue and invoke connectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -75,3 +75,51 @@
|
||||||
[Custom Elements: disconnectedCallback]
|
[Custom Elements: disconnectedCallback]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from the document must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from the document must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from the document of the template elements must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from the document of the template elements must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from a new document must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from a new document must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from a cloned document must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from a cloned document must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from a document created by createHTMLDocument must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from a document created by createHTMLDocument must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from an HTML document created by createDocument must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from an HTML document created by createDocument must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from the document of an iframe must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from the document of an iframe must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing a custom element from an HTML document fetched by XHR must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[Removing an ancestor of custom element from an HTML document fetched by XHR must enqueue and invoke disconnectedCallback]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -0,0 +1,23 @@
|
||||||
|
[ChildNode.html]
|
||||||
|
type: testharness
|
||||||
|
[before on ChildNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[before on ChildNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[after on ChildNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[after on ChildNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[replaceWith on ChildNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[replaceWith on ChildNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[replaceWith on ChildNode must enqueue a disconnected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
|
@ -21,3 +21,15 @@
|
||||||
[importNode on Document must construct a new custom element when importing a custom element from a template]
|
[importNode on Document must construct a new custom element when importing a custom element from a template]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[adoptNode on Document must enqueue an adopted reaction when importing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[title on Document must enqueue disconnectedCallback when removing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[write on Document must enqueue connectedCallback after constructing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[writeln on Document must enqueue connectedCallback after constructing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -69,3 +69,15 @@
|
||||||
[insertAdjacentHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element]
|
[insertAdjacentHTML on Element must enqueue a attributeChanged reaction for a newly constructed custom element]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[insertAdjacentElement on Element must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[insertAdjacentElement on Element must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[innerHTML on Element must enqueue a disconnected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[outerHTML on Element must enqueue a disconnected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -6,3 +6,12 @@
|
||||||
[add on HTMLOptionsCollection must enqueue connectedCallback when inserting a custom element]
|
[add on HTMLOptionsCollection must enqueue connectedCallback when inserting a custom element]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[length on HTMLOptionsCollection must enqueue disconnectedCallback when removing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[The indexed setter on HTMLOptionsCollection must enqueue disconnectedCallback when removing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[remove on HTMLOptionsCollection must enqueue disconnectedCallback when removing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -9,3 +9,9 @@
|
||||||
[add on HTMLSelectElement must enqueue connectedCallback when inserting a custom element]
|
[add on HTMLSelectElement must enqueue connectedCallback when inserting a custom element]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[length on HTMLSelectElement must enqueue disconnectedCallback when removing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[remove on HTMLSelectElement must enqueue disconnectedCallback when removing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -0,0 +1,5 @@
|
||||||
|
[HTMLTitleElement.html]
|
||||||
|
type: testharness
|
||||||
|
[text on HTMLTitleElement must enqueue disconnectedCallback when removing a custom element]
|
||||||
|
expected: FAIL
|
||||||
|
|
|
@ -15,3 +15,24 @@
|
||||||
[cloneNode on Node must enqueue an attributeChanged reaction when cloning an element only for observed attributes]
|
[cloneNode on Node must enqueue an attributeChanged reaction when cloning an element only for observed attributes]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[insertBefore on ChildNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[insertBefore on ChildNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[appendChild on ChildNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[appendChild on ChildNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[replaceChild on ChildNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[replaceChild on ChildNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[removeChild on ChildNode must enqueue a disconnected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
|
@ -0,0 +1,14 @@
|
||||||
|
[ParentNode.html]
|
||||||
|
type: testharness
|
||||||
|
[prepend on ParentNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[prepend on ParentNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[append on ParentNode must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[append on ParentNode must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
|
@ -15,3 +15,18 @@
|
||||||
[createContextualFragment on Range must construct a custom element]
|
[createContextualFragment on Range must construct a custom element]
|
||||||
expected: FAIL
|
expected: FAIL
|
||||||
|
|
||||||
|
[deleteContents on Range must enqueue a disconnected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[insertNode on Range must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[insertNode on Range must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[surroundContents on Range must enqueue a connected reaction]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
[surroundContents on Range must enqueue a disconnected reaction, an adopted reaction, and a connected reaction when the custom element was in another document]
|
||||||
|
expected: FAIL
|
||||||
|
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue