Auto merge of #6285 - mbrubeck:nofile, r=metajack

* Don't hang silently when passed a non-existant file.
* Fix uncaught exception in `mach run` when Servo fails.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6285)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2015-06-04 15:53:11 -05:00
commit 9b5a01e045
3 changed files with 14 additions and 3 deletions

View file

@ -8,7 +8,7 @@
#![feature(core)] #![feature(core)]
#![feature(exit_status)] #![feature(exit_status)]
#![feature(optin_builtin_traits)] #![feature(optin_builtin_traits)]
#![cfg_attr(not(target_os = "android"), feature(path_ext))] #![feature(path_ext)]
#![feature(plugin)] #![feature(plugin)]
#![feature(rustc_private)] #![feature(rustc_private)]
#![feature(step_by)] #![feature(step_by)]

View file

@ -16,7 +16,9 @@ use std::collections::HashSet;
use std::cmp; use std::cmp;
use std::env; use std::env;
use std::io::{self, Write}; use std::io::{self, Write};
use std::fs::PathExt;
use std::mem; use std::mem;
use std::path::Path;
use std::ptr; use std::ptr;
use url::{self, Url}; use url::{self, Url};
@ -310,8 +312,14 @@ pub fn from_cmdline_args(args: &[String]) -> bool {
let cwd = env::current_dir().unwrap(); let cwd = env::current_dir().unwrap();
match Url::parse(url) { match Url::parse(url) {
Ok(url) => url, Ok(url) => url,
Err(url::ParseError::RelativeUrlWithoutBase) Err(url::ParseError::RelativeUrlWithoutBase) => {
=> Url::from_file_path(&*cwd.join(url)).unwrap(), if Path::new(url).exists() {
Url::from_file_path(&*cwd.join(url)).unwrap()
} else {
args_fail(&format!("File not found: {}", url));
return false;
}
}
Err(_) => panic!("URL parsing failed"), Err(_) => panic!("URL parsing failed"),
} }
}; };

View file

@ -80,6 +80,9 @@ class MachCommands(CommandBase):
try: try:
subprocess.check_call(args, env=env) subprocess.check_call(args, env=env)
except subprocess.CalledProcessError as e:
print("Servo exited with return value %d" % e.returncode)
return e.returncode
except OSError as e: except OSError as e:
if e.errno == 2: if e.errno == 2:
print("Servo Binary can't be found! Run './mach build'" print("Servo Binary can't be found! Run './mach build'"