From 9b6c5da98fa1555f03ff3161a4d12cad6b9a6b57 Mon Sep 17 00:00:00 2001 From: Hiroyuki Ikezoe Date: Thu, 4 Jan 2018 19:23:25 +0900 Subject: [PATCH] Don't fill out deficient animation/transition property values in the style struct --- components/style/properties/gecko.mako.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/components/style/properties/gecko.mako.rs b/components/style/properties/gecko.mako.rs index 2d3907b23d0..d25a6516930 100644 --- a/components/style/properties/gecko.mako.rs +++ b/components/style/properties/gecko.mako.rs @@ -2948,8 +2948,8 @@ fn static_assert() { let count = other.gecko.m${type.capitalize()}${gecko_ffi_name}Count; self.gecko.m${type.capitalize()}${gecko_ffi_name}Count = count; - let iter = self.gecko.m${type.capitalize()}s.iter_mut().zip( - other.gecko.m${type.capitalize()}s.iter().take(count as usize).cycle() + let iter = self.gecko.m${type.capitalize()}s.iter_mut().take(count as usize).zip( + other.gecko.m${type.capitalize()}s.iter() ); for (ours, others) in iter { @@ -2982,7 +2982,7 @@ fn static_assert() { self.gecko.m${type.capitalize()}s.ensure_len(input_len); self.gecko.m${type.capitalize()}${gecko_ffi_name}Count = input_len as u32; - for (gecko, servo) in self.gecko.m${type.capitalize()}s.iter_mut().zip(v.cycle()) { + for (gecko, servo) in self.gecko.m${type.capitalize()}s.iter_mut().take(input_len as usize).zip(v) { gecko.m${gecko_ffi_name} = servo.seconds() * 1000.; } } @@ -3007,7 +3007,7 @@ fn static_assert() { self.gecko.m${type.capitalize()}s.ensure_len(input_len); self.gecko.m${type.capitalize()}TimingFunctionCount = input_len as u32; - for (gecko, servo) in self.gecko.m${type.capitalize()}s.iter_mut().zip(v.cycle()) { + for (gecko, servo) in self.gecko.m${type.capitalize()}s.iter_mut().take(input_len as usize).zip(v) { gecko.mTimingFunction = servo.into(); } } @@ -3064,7 +3064,7 @@ fn static_assert() { self.gecko.mAnimation${gecko_ffi_name}Count = input_len as u32; - for (gecko, servo) in self.gecko.mAnimations.iter_mut().zip(v.cycle()) { + for (gecko, servo) in self.gecko.mAnimations.iter_mut().take(input_len as usize).zip(v) { let result = match servo { % for value in keyword.gecko_values(): Keyword::${to_camel_case(value)} => @@ -3465,7 +3465,7 @@ fn static_assert() { self.gecko.mAnimations.ensure_len(input_len); self.gecko.mAnimationIterationCountCount = input_len as u32; - for (gecko, servo) in self.gecko.mAnimations.iter_mut().zip(v.cycle()) { + for (gecko, servo) in self.gecko.mAnimations.iter_mut().take(input_len as usize).zip(v) { match servo { AnimationIterationCount::Number(n) => gecko.mIterationCount = n, AnimationIterationCount::Infinite => gecko.mIterationCount = f32::INFINITY,