Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

fix: meta referrer updating to follow spec (#36390)

Browse source 
Previously the referrer policy used tree order but the spec only cares
about the most-recently-updated or most-recently-added meta referrer.

Testing: change has existing WPT tests

---------

Signed-off-by: Sebastian C <sebsebmc@gmail.com>
This commit is contained in:
Sebastian C 2025-04-07 17:29:12 -05:00 • committed by GitHub
parent bfbe464eba
commit 9bdc46d66b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 28 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

32
components/script/dom/htmlmetaelement.rs
View file

@ -8,7 +8,7 @@ use std::time::Duration;
use constellation_traits::NavigationHistoryBehavior;
use dom_struct::dom_struct;
use html5ever::{LocalName, Prefix};
use html5ever::{LocalName, Prefix, local_name, namespace_url, ns};
use js::rust::HandleObject;
use regex::bytes::Regex;
use servo_url::ServoUrl;
@ -21,7 +21,7 @@ use crate::dom::bindings::codegen::Bindings::WindowBinding::WindowMethods;
use crate::dom::bindings::inheritance::Castable;
use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::DOMString;
use crate::dom::document::{DeclarativeRefresh, Document};
use crate::dom::document::{DeclarativeRefresh, Document, determine_policy_for_token};
use crate::dom::element::{AttributeMutation, Element};
use crate::dom::htmlelement::HTMLElement;
use crate::dom::htmlheadelement::HTMLHeadElement;
@ -115,9 +115,31 @@ impl HTMLMetaElement {
/// <https://html.spec.whatwg.org/multipage/#meta-referrer>
fn apply_referrer(&self) {
if let Some(parent) = self.upcast::<Node>().GetParentElement() {
if let Some(head) = parent.downcast::<HTMLHeadElement>() {
head.set_document_referrer();
let doc = self.owner_document();
// From spec: For historical reasons, unlike other standard metadata names, the processing model for referrer
// is not responsive to element removals, and does not use tree order. Only the most-recently-inserted or
// most-recently-modified meta element in this state has an effect.
// 1. If element is not in a document tree, then return.
let meta_node = self.upcast::<Node>();
if !meta_node.is_in_a_document_tree() {
return;
}
// 2. If element does not have a name attribute whose value is an ASCII case-insensitive match for "referrer",
// then return.
if self.upcast::<Element>().get_name() != Some(atom!("referrer")) {
return;
}
// 3. If element does not have a content attribute, or that attribute's value is the empty string, then return.
let content = self
.upcast::<Element>()
.get_attribute(&ns!(), &local_name!("content"));
if let Some(attr) = content {
let attr = attr.value();
let attr_val = attr.trim();
if !attr_val.is_empty() {
doc.set_referrer_policy(determine_policy_for_token(attr_val));
}
}
}