Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Disallow :has selector nesting

Browse source 
Unlike the `ParseRelative` flag, which turns on relative selector parsing for
that parsing level only, the newly added `DISALLOW_RELATIVE_SELECTOR` flag
propagates through nested parsing calls.

Differential Revision: https://phabricator.services.mozilla.com/D176807
This commit is contained in:
David Shin 2023-05-15 13:33:01 +00:00 • committed by Martin Robinson
parent 9c7e0930c3
commit 9c58f0c635
1 changed files with 12 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
components/selectors/parser.rs
View file

@ -119,6 +119,9 @@ bitflags! {
/// Whether we explicitly disallow pseudo-element-like things.
const DISALLOW_PSEUDOS = 1 << 6;
/// Whether we explicitly disallow relative selectors (i.e. `:has()`).
const DISALLOW_RELATIVE_SELECTOR = 1 << 7;
}
}
@ -2942,12 +2945,20 @@ where
Impl: SelectorImpl,
{
debug_assert!(parser.parse_has());
if state.intersects(SelectorParsingState::DISALLOW_RELATIVE_SELECTOR) {
return Err(input.new_custom_error(SelectorParseErrorKind::InvalidState));
}
// Nested `:has()` is disallowed, mark it as such.
// Note: The spec defines ":has-allowed pseudo-element," but there's no
// pseudo-element defined as such at the moment.
// https://w3c.github.io/csswg-drafts/selectors-4/#has-allowed-pseudo-element
let inner = SelectorList::parse_with_state(
parser,
input,
state |
SelectorParsingState::SKIP_DEFAULT_NAMESPACE |
SelectorParsingState::DISALLOW_PSEUDOS,
SelectorParsingState::DISALLOW_PSEUDOS |
SelectorParsingState::DISALLOW_RELATIVE_SELECTOR,
ForgivingParsing::No,
ParseRelative::Yes,
)?;