From 9d679c9b205b9de9f8213131432848f54213ecf1 Mon Sep 17 00:00:00 2001 From: Gerald Squelart Date: Thu, 31 May 2018 18:22:48 +1000 Subject: [PATCH] style: Ignore case in media feature names inside media query expressions. Media feature names are converted to lower case before being processed, making them effectively case-insensitive. Prefixes ("min-", etc.) and values are already treated in a case-insensitive manner. Bug: 1464091 Reviewed-by: heycam MozReview-Commit-ID: JUeeEQEMIi4 --- components/style/gecko/media_queries.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/style/gecko/media_queries.rs b/components/style/gecko/media_queries.rs index 554606bb9db..833db60a037 100644 --- a/components/style/gecko/media_queries.rs +++ b/components/style/gecko/media_queries.rs @@ -23,7 +23,7 @@ use properties::ComputedValues; use servo_arc::Arc; use std::fmt::{self, Write}; use std::sync::atomic::{AtomicBool, AtomicIsize, AtomicUsize, Ordering}; -use str::starts_with_ignore_ascii_case; +use str::{starts_with_ignore_ascii_case, string_as_ascii_lowercase}; use string_cache::Atom; use style_traits::{CSSPixel, CssWriter, DevicePixel}; use style_traits::{ParseError, StyleParseErrorKind, ToCss}; @@ -596,7 +596,7 @@ impl Expression { Range::Equal }; - let atom = Atom::from(feature_name); + let atom = Atom::from(string_as_ascii_lowercase(feature_name)); match find_feature(|f| atom.as_ptr() == unsafe { *f.mName as *mut _ }) { Some(f) => Ok((f, range)), None => Err(()),