From 9dc56d420fdcd18d5dfd7bfec6e641f1e224c513 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20W=C3=BClker?= <simon.wuelker@arcor.de>
Date: Thu, 24 Apr 2025 13:59:54 +0200
Subject: [PATCH] servoshell: Make list of options in <select> prompt
 scrollable (#36677)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This ensures that the select element is usable when there are a lot of
options.

Testing: We don't have tests for servoshell.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
---
 ports/servoshell/desktop/dialog.rs | 40 ++++++++++++++++--------------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/ports/servoshell/desktop/dialog.rs b/ports/servoshell/desktop/dialog.rs
index 2bfccb523de..c113682de56 100644
--- a/ports/servoshell/desktop/dialog.rs
+++ b/ports/servoshell/desktop/dialog.rs
@@ -449,32 +449,34 @@ impl Dialog {
 
                 let modal = Modal::new("select_element_picker".into()).area(area);
                 modal.show(ctx, |ui| {
-                    for option_or_optgroup in prompt.options() {
-                        match &option_or_optgroup {
-                            SelectElementOptionOrOptgroup::Option(option) => {
-                                display_option(
-                                    ui,
-                                    option,
-                                    &mut selected_option,
-                                    &mut is_open,
-                                    false,
-                                );
-                            },
-                            SelectElementOptionOrOptgroup::Optgroup { label, options } => {
-                                ui.label(egui::RichText::new(label).strong());
-
-                                for option in options {
+                    egui::ScrollArea::vertical().show(ui, |ui| {
+                        for option_or_optgroup in prompt.options() {
+                            match &option_or_optgroup {
+                                SelectElementOptionOrOptgroup::Option(option) => {
                                     display_option(
                                         ui,
                                         option,
                                         &mut selected_option,
                                         &mut is_open,
-                                        true,
+                                        false,
                                     );
-                                }
-                            },
+                                },
+                                SelectElementOptionOrOptgroup::Optgroup { label, options } => {
+                                    ui.label(egui::RichText::new(label).strong());
+
+                                    for option in options {
+                                        display_option(
+                                            ui,
+                                            option,
+                                            &mut selected_option,
+                                            &mut is_open,
+                                            true,
+                                        );
+                                    }
+                                },
+                            }
                         }
-                    }
+                    });
                 });
 
                 prompt.select(selected_option);