Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

compositor: Remove some unused messages to the compositor (#35223)

Browse source 
Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2025-01-30 10:21:23 +01:00 • committed by GitHub
parent 8813f52b20
commit 9eeb602f7a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 0 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

29
components/compositing/compositor.rs
View file

@ -517,35 +517,6 @@ impl IOCompositor {
self.remove_webview(top_level_browsing_context_id); self.remove_webview(top_level_browsing_context_id);
}, },
// TODO: remove this
CompositorMsg::MoveResizeWebView(webview_id, rect) => {
self.move_resize_webview(webview_id, rect);
},
// TODO: remove this
CompositorMsg::ShowWebView(webview_id, hide_others) => {
if let Err(UnknownWebView(webview_id)) = self.show_webview(webview_id, hide_others)
{
warn!("{webview_id}: ShowWebView on unknown webview id");
}
},
// TODO: remove this
CompositorMsg::HideWebView(webview_id) => {
if let Err(UnknownWebView(webview_id)) = self.hide_webview(webview_id) {
warn!("{webview_id}: HideWebView on unknown webview id");
}
},
// TODO: remove this
CompositorMsg::RaiseWebViewToTop(webview_id, hide_others) => {
if let Err(UnknownWebView(webview_id)) =
self.raise_webview_to_top(webview_id, hide_others)
{
warn!("{webview_id}: RaiseWebViewToTop on unknown webview id");
}
},
CompositorMsg::TouchEventProcessed(result) => { CompositorMsg::TouchEventProcessed(result) => {
self.touch_handler.on_event_processed(result); self.touch_handler.on_event_processed(result);
}, },

4
components/compositing/tracing.rs
View file

@ -34,10 +34,6 @@ mod from_constellation {
Self::ChangeRunningAnimationsState(..) => target!("ChangeRunningAnimationsState"), Self::ChangeRunningAnimationsState(..) => target!("ChangeRunningAnimationsState"),
Self::CreateOrUpdateWebView(..) => target!("CreateOrUpdateWebView"), Self::CreateOrUpdateWebView(..) => target!("CreateOrUpdateWebView"),
Self::RemoveWebView(..) => target!("RemoveWebView"), Self::RemoveWebView(..) => target!("RemoveWebView"),
Self::MoveResizeWebView(..) => target!("MoveResizeWebView"),
Self::ShowWebView(..) => target!("ShowWebView"),
Self::HideWebView(..) => target!("HideWebView"),
Self::RaiseWebViewToTop(..) => target!("RaiseWebViewToTop"),
Self::TouchEventProcessed(..) => target!("TouchEventProcessed"), Self::TouchEventProcessed(..) => target!("TouchEventProcessed"),
Self::CreatePng(..) => target!("CreatePng"), Self::CreatePng(..) => target!("CreatePng"),
Self::IsReadyToSaveImageReply(..) => target!("IsReadyToSaveImageReply"), Self::IsReadyToSaveImageReply(..) => target!("IsReadyToSaveImageReply"),

13
components/shared/compositing/lib.rs
View file

@ -19,7 +19,6 @@ use log::warn;
use pixels::Image; use pixels::Image;
use script_traits::{AnimationState, ConstellationControlMsg, EventResult}; use script_traits::{AnimationState, ConstellationControlMsg, EventResult};
use style_traits::CSSPixel; use style_traits::CSSPixel;
use webrender_api::units::DeviceRect;
use webrender_api::DocumentId; use webrender_api::DocumentId;
use webrender_traits::{CrossProcessCompositorApi, CrossProcessCompositorMessage}; use webrender_traits::{CrossProcessCompositorApi, CrossProcessCompositorMessage};
@ -69,14 +68,6 @@ pub enum CompositorMsg {
CreateOrUpdateWebView(SendableFrameTree), CreateOrUpdateWebView(SendableFrameTree),
/// Remove a webview. /// Remove a webview.
RemoveWebView(TopLevelBrowsingContextId), RemoveWebView(TopLevelBrowsingContextId),
/// Move and/or resize a webview to the given rect.
MoveResizeWebView(TopLevelBrowsingContextId, DeviceRect),
/// Start painting a webview, and optionally stop painting all others.
ShowWebView(TopLevelBrowsingContextId, bool),
/// Stop painting a webview.
HideWebView(TopLevelBrowsingContextId),
/// Start painting a webview on top of all others, and optionally stop painting all others.
RaiseWebViewToTop(TopLevelBrowsingContextId, bool),
/// Script has handled a touch event, and either prevented or allowed default actions. /// Script has handled a touch event, and either prevented or allowed default actions.
TouchEventProcessed(EventResult), TouchEventProcessed(EventResult),
/// Composite to a PNG file and return the Image over a passed channel. /// Composite to a PNG file and return the Image over a passed channel.
@ -133,10 +124,6 @@ impl Debug for CompositorMsg {
}, },
CompositorMsg::CreateOrUpdateWebView(..) => write!(f, "CreateOrUpdateWebView"), CompositorMsg::CreateOrUpdateWebView(..) => write!(f, "CreateOrUpdateWebView"),
CompositorMsg::RemoveWebView(..) => write!(f, "RemoveWebView"), CompositorMsg::RemoveWebView(..) => write!(f, "RemoveWebView"),
CompositorMsg::MoveResizeWebView(..) => write!(f, "MoveResizeWebView"),
CompositorMsg::ShowWebView(..) => write!(f, "ShowWebView"),
CompositorMsg::HideWebView(..) => write!(f, "HideWebView"),
CompositorMsg::RaiseWebViewToTop(..) => write!(f, "RaiseWebViewToTop"),
CompositorMsg::TouchEventProcessed(..) => write!(f, "TouchEventProcessed"), CompositorMsg::TouchEventProcessed(..) => write!(f, "TouchEventProcessed"),
CompositorMsg::CreatePng(..) => write!(f, "CreatePng"), CompositorMsg::CreatePng(..) => write!(f, "CreatePng"),
CompositorMsg::IsReadyToSaveImageReply(..) => write!(f, "IsReadyToSaveImageReply"), CompositorMsg::IsReadyToSaveImageReply(..) => write!(f, "IsReadyToSaveImageReply"),