Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove unnecessary join()s from GitHub Actions (#30040)

Browse source 
`contains()` works on arrays as well as strings, so the `join` is
unnecessary when trying to detect job statuses.
This commit is contained in:
Martin Robinson 2023-07-28 07:26:19 +02:00 • committed by GitHub
parent 2ecdb8f45e
commit 9fa67685f4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/linux.yml vendored
View file

@ -144,8 +144,8 @@ jobs:
steps: steps:
- name: Mark the job as successful - name: Mark the job as successful
run: exit 0 run: exit 0
if: ${{ !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') }} if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}
- name: Mark the job as unsuccessful - name: Mark the job as unsuccessful
run: exit 1 run: exit 1
if: contains(join(needs.*.result, ','), 'failure') || contains(join(needs.*.result, ','), 'cancelled') if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')

4
.github/workflows/mac.yml vendored
View file

@ -154,7 +154,7 @@ jobs:
steps: steps:
- name: Mark the job as successful - name: Mark the job as successful
run: exit 0 run: exit 0
if: ${{ !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') }} if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}
- name: Mark the job as unsuccessful - name: Mark the job as unsuccessful
run: exit 1 run: exit 1
if: contains(join(needs.*.result, ','), 'failure') || contains(join(needs.*.result, ','), 'cancelled') if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')

4
.github/workflows/main.yml vendored
View file

@ -128,8 +128,8 @@ jobs:
if: ${{ fromJson(needs.decision.outputs.configuration).platform == 'none' }} if: ${{ fromJson(needs.decision.outputs.configuration).platform == 'none' }}
run: exit 0 run: exit 0
- name: Mark the job as successful - name: Mark the job as successful
if: ${{ !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') }} if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}
run: exit 0 run: exit 0
- name: Mark the job as unsuccessful - name: Mark the job as unsuccessful
if: contains(join(needs.*.result, ','), 'failure') || contains(join(needs.*.result, ','), 'cancelled') if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
run: exit 1 run: exit 1

4
.github/workflows/try.yml vendored
View file

@ -90,7 +90,7 @@ jobs:
if: ${{ always() && fromJson(needs.parse-comment.outputs.configuration).try}} if: ${{ always() && fromJson(needs.parse-comment.outputs.configuration).try}}
steps: steps:
- name: Success - name: Success
if: ${{ !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') }} if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}
uses: actions/github-script@v6 uses: actions/github-script@v6
with: with:
script: | script: |
@ -106,7 +106,7 @@ jobs:
body: "✨ Try run (" + formattedURL + ") " + "succeeded.", body: "✨ Try run (" + formattedURL + ") " + "succeeded.",
}); });
- name: Failure - name: Failure
if: ${{ contains(join(needs.*.result, ','), 'failure') }} if: ${{ contains(needs.*.result, 'failure') }}
uses: actions/github-script@v6 uses: actions/github-script@v6
with: with:
script: | script: |

4
.github/workflows/windows.yml vendored
View file

@ -103,8 +103,8 @@ jobs:
steps: steps:
- name: Mark the job as successful - name: Mark the job as successful
run: exit 0 run: exit 0
if: ${{ !contains(join(needs.*.result, ','), 'failure') && !contains(join(needs.*.result, ','), 'cancelled') }} if: ${{ !contains(needs.*.result, 'failure') && !contains(needs.*.result, 'cancelled') }}
- name: Mark the job as unsuccessful - name: Mark the job as unsuccessful
run: exit 1 run: exit 1
if: contains(join(needs.*.result, ','), 'failure') || contains(join(needs.*.result, ','), 'cancelled') if: contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')