Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Avoid computing and storing change hints for text nodes.

Browse source
This commit is contained in:
Emilio Cobos Álvarez 2016-08-20 01:42:17 -07:00
parent 278bef474c
commit 9feea76043
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
1 changed files with 16 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

24
components/style/matching.rs
View file

@ -871,21 +871,29 @@ pub trait MatchMethods : TNode {
None => None, None => None,
}; };
let mut applicable_declarations_cache =
context.local_context().applicable_declarations_cache.borrow_mut();
let (damage, restyle_result) = if self.is_text_node() { // In the case we're styling a text node, we don't need to compute the
// restyle damage, since it's a subset of the restyle damage of the
// parent.
//
// In Gecko, we're done, we don't need anything else from text nodes.
//
// In Servo, this is also true, since text nodes generate UnscannedText
// fragments, which aren't repairable by incremental layout.
if self.is_text_node() {
let mut data_ref = self.mutate_data().unwrap(); let mut data_ref = self.mutate_data().unwrap();
let mut data = &mut *data_ref; let mut data = &mut *data_ref;
let cloned_parent_style = ComputedValues::style_for_child_text_node(parent_style.unwrap()); let cloned_parent_style = ComputedValues::style_for_child_text_node(parent_style.unwrap());
let damage =
self.compute_restyle_damage(data.style.as_ref(), &cloned_parent_style, None);
data.style = Some(cloned_parent_style); data.style = Some(cloned_parent_style);
(damage, RestyleResult::Continue) return RestyleResult::Continue;
} else { }
let mut applicable_declarations_cache =
context.local_context().applicable_declarations_cache.borrow_mut();
let (damage, restyle_result) = {
let mut data_ref = self.mutate_data().unwrap(); let mut data_ref = self.mutate_data().unwrap();
let mut data = &mut *data_ref; let mut data = &mut *data_ref;
let final_style = let final_style =