Don't build testbinding-related code by default (#37034)

Disabling the TestBinding-related bindings and implementations saves 2mb
in a release build. Also, we lost the related test preferences when we
turned the layout-2020 tests on, so the tests have all been failing for
a long time.

Testing: Existing tests in CI.

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2025-05-17 10:14:19 +02:00 committed by GitHub
parent 2eab9c6df1
commit a028291466
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
35 changed files with 72 additions and 149 deletions

View file

@ -13940,7 +13940,7 @@
]
],
"preferences.html": [
"a1da58a825e2832c7eb55a87322b7ba840ee2661",
"8a65161198c3a692aa007b98643ae3e95b0ae310",
[
null,
{}

View file

@ -1,5 +1,15 @@
prefs: [
"dom_serviceworker_enabled:true",
"dom_servo_helpers_enabled:true",
"dom_testbinding_enabled:true",
"dom_testbinding_prefcontrolled_enabled:false",
"dom_testbinding_prefcontrolled2_enabled:true",
"dom_testbinding_preference_value_falsy:false",
"dom_testbinding_preference_value_quote_string_test:\"test\"",
"dom_testbinding_preference_value_space_string_test:test1 test2",
"dom_testbinding_preference_value_string_empty:",
"dom_testbinding_preference_value_string_test:test",
"dom_testbinding_preference_value_truthy:true",
"dom_urlpattern_enabled:true",
"media_testing_enabled:true",
]

View file

@ -1,4 +0,0 @@
[binding_keyword.html]
[Conversion of dictionary elements with rust keywords, and null non-required nullable properties works]
expected: FAIL

View file

@ -1,4 +0,0 @@
[codegen_unions.html]
[(DOMString or object) conversion is performed correctly]
expected: FAIL

View file

@ -1,4 +0,0 @@
[custom_auto_rooter.html]
[sequence<any> conversion did not lose any values]
expected: FAIL

View file

@ -1,7 +0,0 @@
[entry.html]
[Incumbent global]
expected: FAIL
[Entry global]
expected: FAIL

View file

@ -1,4 +0,0 @@
[entry.worker.html]
[entry]
expected: FAIL

View file

@ -1,62 +0,0 @@
[interface_member_exposed.html]
expected: ERROR
[Disabled preference hides member controlled by that preference: funcControlledStaticMethodDisabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: prefControlledAttributeDisabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: prefControlledMethodEnabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: prefControlledConstEnabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: funcControlledAttributeEnabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: prefControlledStaticAttributeDisabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: funcControlledMethodDisabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: prefControlledStaticMethodEnabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: prefControlledStaticAttributeEnabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: prefControlledStaticMethodDisabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: prefControlledAttributeEnabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: funcControlledStaticMethodEnabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: funcControlledConstDisabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: prefControlledConstDisabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: funcControlledMethodEnabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: funcControlledAttributeDisabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: funcControlledStaticAttributeEnabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: funcControlledStaticAttributeDisabled]
expected: FAIL
[Enabled preference shows member controlled by that preference: funcControlledConstEnabled]
expected: FAIL
[Disabled preference hides member controlled by that preference: prefControlledMethodDisabled]
expected: FAIL

View file

@ -1 +1 @@
prefs: [dom_webxr_test: false, dom_testutils_enabled: false]
prefs: [dom_webxr_test: false, dom_testutils_enabled: false, dom_testbinding_enabled: false]

View file

@ -1 +1 @@
prefs: [dom_testutils_enabled: false]
prefs: [dom_testutils_enabled: false, dom_testbinding_enabled: false]

View file

@ -1,19 +0,0 @@
[iterable.html]
[Iterable iterators are iterators]
expected: FAIL
[Pair iterable iterators are iterators]
expected: FAIL
[Empty value iterator]
expected: FAIL
[Empty pair iterator]
expected: FAIL
[Iterators iterate over values]
expected: FAIL
[Pair iterators iterate over key/value pairs]
expected: FAIL

View file

@ -1,4 +1,3 @@
[navigator.html]
[navigator.platform mac]
expected: FAIL

View file

@ -1,4 +0,0 @@
[preferences.html]
[prefs]
expected: FAIL

View file

@ -1,19 +0,0 @@
[promise.html]
[Resolve callback gets argument]
expected: FAIL
[Native promise from async callback can be resolved]
expected: FAIL
[Native reject callback gets argument]
expected: FAIL
[Native code rejects with exception]
expected: FAIL
[Reject callback gets argument]
expected: FAIL
[Native resolve callback gets argument]
expected: FAIL

View file

@ -1,7 +0,0 @@
[variadic-interface.html]
[Default values and variadic arguments work together.]
expected: FAIL
[Variadic interface arguments work.]
expected: FAIL

View file

@ -7,16 +7,16 @@
test(function() {
var testBinding = new TestBinding();
assert_equals(typeof testBinding.BooleanMozPreference, "function");
assert_equals(testBinding.BooleanMozPreference("dom.testbinding.preference_value.falsy"), false);
assert_equals(testBinding.BooleanMozPreference("dom.testbinding.preference_value.truthy"), true);
assert_equals(testBinding.BooleanMozPreference("dom.testbinding.preference_value.string_test"), false);
assert_equals(testBinding.BooleanMozPreference("dom.testbinding.preference_value.string_empty"), false);
assert_equals(testBinding.BooleanMozPreference("dom_testbinding_preference_value_falsy"), false);
assert_equals(testBinding.BooleanMozPreference("dom_testbinding_preference_value_truthy"), true);
assert_equals(testBinding.BooleanMozPreference("dom_testbinding_preference_value_string_test"), false);
assert_equals(testBinding.BooleanMozPreference("dom_testbinding_preference_value_string_empty"), false);
assert_equals(typeof testBinding.StringMozPreference, "function");
assert_equals(testBinding.StringMozPreference("dom.testbinding.preference_value.string_test"), "test");
assert_equals(testBinding.StringMozPreference("dom.testbinding.preference_value.string_empty"), "");
assert_equals(testBinding.StringMozPreference("dom.testbinding.preference_value.falsy"), "");
assert_equals(testBinding.StringMozPreference("dom.testbinding.preference_value.truthy"), "");
assert_equals(testBinding.StringMozPreference("dom.testbinding.preference_value.space_string_test"), "test1 test2");
assert_equals(testBinding.StringMozPreference("dom.testbinding.preference_value.space_string_test"), "test1 test2");
assert_equals(testBinding.StringMozPreference("dom_testbinding_preference_value_string_test"), "test");
assert_equals(testBinding.StringMozPreference("dom_testbinding_preference_value_string_empty"), "");
assert_equals(testBinding.StringMozPreference("dom_testbinding_preference_value_falsy"), "");
assert_equals(testBinding.StringMozPreference("dom_testbinding_preference_value_truthy"), "");
assert_equals(testBinding.StringMozPreference("dom_testbinding_preference_value_space_string_test"), "test1 test2");
assert_equals(testBinding.StringMozPreference("dom_testbinding_preference_value_quote_string_test"), "\"test\"");
}, "prefs");
</script>