Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 12:40:06 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make tidy.py check for links to spec pages. [Issue#5730]

Browse source
This commit is contained in:
Dhananjay Nakrani 2015-04-19 12:42:59 -07:00
parent a3dafe4999
commit a0295b7489
1 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

12
python/tidy.py
View file

@ -12,6 +12,7 @@
import os import os
import fnmatch import fnmatch
import itertools import itertools
import re
from licenseck import licenses from licenseck import licenses
directories_to_check = ["ports", "components", "tests"] directories_to_check = ["ports", "components", "tests"]
@ -72,6 +73,15 @@ def check_length(contents):
if len(line) >= 160: if len(line) >= 160:
yield (idx + 1, "(much) overlong line") yield (idx + 1, "(much) overlong line")
def check_whatwg_url(contents):
lines = contents.splitlines(True)
for idx, line in enumerate(lines):
matches = re.findall(r'whatwg.org/multipage.*#', line);
if matches:
for i, match in enumerate(matches):
parts = match.split('multipage')
if len(parts[1]) > 1 and parts[1][1] != '#':
yield (idx + 1, "URL should not point to specific WHATWG multipage page!")
def check_whitespace(contents): def check_whitespace(contents):
lines = contents.splitlines(True) lines = contents.splitlines(True)
@ -127,7 +137,7 @@ def scan():
all_files = collect_file_names(directories_to_check) all_files = collect_file_names(directories_to_check)
files_to_check = filter(should_check, all_files) files_to_check = filter(should_check, all_files)
checking_functions = [check_license, check_length, check_whitespace] checking_functions = [check_license, check_length, check_whitespace, check_whatwg_url]
errors = collect_errors_for_files(files_to_check, checking_functions) errors = collect_errors_for_files(files_to_check, checking_functions)
reftest_files = collect_file_names(reftest_directories) reftest_files = collect_file_names(reftest_directories)