From e6a3a9774ad2f84cf6dbee531cf5e501076761b0 Mon Sep 17 00:00:00 2001 From: marmeladema Date: Thu, 12 Dec 2019 00:14:32 +0000 Subject: [PATCH] Use filename instead of already opened file descriptor when calling ZipFile This should fix #25251 --- python/servo/command_base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/servo/command_base.py b/python/servo/command_base.py index 86121b38fb0..15ec195fd51 100644 --- a/python/servo/command_base.py +++ b/python/servo/command_base.py @@ -112,7 +112,7 @@ def archive_deterministically(dir_to_archive, dest_archive, prepend_path=None): temp_file = '{}.temp~'.format(dest_archive) with os.fdopen(os.open(temp_file, os.O_WRONLY | os.O_CREAT, 0o644), 'wb') as out_file: if dest_archive.endswith('.zip'): - with zipfile.ZipFile(out_file, 'w', zipfile.ZIP_DEFLATED) as zip_file: + with zipfile.ZipFile(temp_file, 'w', zipfile.ZIP_DEFLATED) as zip_file: for entry in file_list: arcname = entry if prepend_path is not None: