Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 21:50:18 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Fire scroll event whenever JS scrolled (#38321)

Browse source 
Implement JS scroll event firing compliant to
https://drafts.csswg.org/cssom-view/#scrolling-events. Basically
whenever, the an element or the viewport is scrolled, we will fire a
scroll event. The changes push a scroll event whenever an API causes a
scroll position to change.

Testing: New WPT tests for basic APIs.
Part of: https://github.com/servo/servo/issues/31665

---------

Signed-off-by: Jo Steven Novaryo <jo.steven.novaryo@huawei.com>
This commit is contained in:
Jo Steven Novaryo 2025-08-01 15:30:22 +08:00 • committed by GitHub
parent 372e5eae59
commit a063b5e78a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 407 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

27
components/script/dom/document.rs
View file

@ -2413,24 +2413,23 @@ impl Document {
// Step 2
// > For each item target in doc’s pending scroll event targets, in the order they
// > were added to the list, run these substeps:
for target in self.pending_scroll_event_targets.borrow().iter() {
// Step 2.1
// > If target is a Document, fire an event named scroll that bubbles at target.
// Step 3.
// > Empty doc’s pending scroll event targets.
// Since the scroll event callback could trigger another scroll event, we are taking all of the
// current scroll event to avoid borrow checking error.
rooted_vec!(let notify_list <- self.pending_scroll_event_targets.take().into_iter());
for target in notify_list.iter() {
if target.downcast::<Document>().is_some() {
// Step 2.1
// > If target is a Document, fire an event named scroll that bubbles at target.
target.fire_bubbling_event(Atom::from("scroll"), can_gc);
}
// Step 2.2
// > Otherwise, fire an event named scroll at target.
if target.downcast::<Element>().is_some() {
} else if target.downcast::<Element>().is_some() {
// Step 2.2
// > Otherwise, fire an event named scroll at target.
target.fire_event(Atom::from("scroll"), can_gc);
}
}
// Step 3.
// > Empty doc’s pending scroll event targets.
self.pending_scroll_event_targets.borrow_mut().clear();
// Step 4.
// > Run the steps to dispatch pending scrollsnapchange events for doc.
// TODO(#7673): Implement scroll snapping
@ -3700,7 +3699,9 @@ impl Document {
receiver.recv().unwrap();
}
self.window().reflow(ReflowGoal::UpdateTheRendering, can_gc)
self.window()
.reflow(ReflowGoal::UpdateTheRendering, can_gc)
.reflow_issued
}
pub(crate) fn id_map(&self) -> Ref<HashMapTracedValues<Atom, Vec<Dom<Element>>>> {