From a0d2b36ad8d48034d6490232e31106ef8b7bfa9d Mon Sep 17 00:00:00 2001
From: Danila Matveev <usurname.r@gmail.com>
Date: Wed, 17 Jul 2024 13:05:02 +0400
Subject: [PATCH] clippy: Fix four warnings (#32789)

* Fixes 4 clippy rules

Signed-off-by: Danila Matveev <usurname.r@gmail.com>

* Rollbacks changes in range.rs and silences clippy::neg_cmp_op_on_partial_ord

Signed-off-by: Danila Matveev <usurname.r@gmail.com>

* Fixes a fmt issue

Signed-off-by: Danila Matveev <usurname.r@gmail.com>

---------

Signed-off-by: Danila Matveev <usurname.r@gmail.com>
---
 components/script/dom/range.rs          | 2 ++
 components/script/dom/resizeobserver.rs | 2 +-
 components/script/dom/window.rs         | 5 +++--
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/components/script/dom/range.rs b/components/script/dom/range.rs
index 3f6b274e958..ce241ef57b1 100644
--- a/components/script/dom/range.rs
+++ b/components/script/dom/range.rs
@@ -333,6 +333,7 @@ impl RangeMethods for Range {
     }
 
     /// <https://dom.spec.whatwg.org/#dom-range-setstart>
+    #[allow(clippy::neg_cmp_op_on_partial_ord)]
     fn SetStart(&self, node: &Node, offset: u32) -> ErrorResult {
         if node.is_doctype() {
             // Step 1.
@@ -352,6 +353,7 @@ impl RangeMethods for Range {
     }
 
     /// <https://dom.spec.whatwg.org/#dom-range-setend>
+    #[allow(clippy::neg_cmp_op_on_partial_ord)]
     fn SetEnd(&self, node: &Node, offset: u32) -> ErrorResult {
         if node.is_doctype() {
             // Step 1.
diff --git a/components/script/dom/resizeobserver.rs b/components/script/dom/resizeobserver.rs
index 48603c7ffc2..0655c562b32 100644
--- a/components/script/dom/resizeobserver.rs
+++ b/components/script/dom/resizeobserver.rs
@@ -272,7 +272,7 @@ fn calculate_box_size(target: &Element, observed_box: &ResizeObserverBoxOptions)
                 .upcast::<Node>()
                 .content_boxes()
                 .pop()
-                .unwrap_or_else(|| Rect::zero())
+                .unwrap_or_else(Rect::zero)
         },
         // TODO(#31182): add support for border box, and device pixel size, calculations.
         _ => Rect::zero(),
diff --git a/components/script/dom/window.rs b/components/script/dom/window.rs
index 480e219d202..e38e0aa54e8 100644
--- a/components/script/dom/window.rs
+++ b/components/script/dom/window.rs
@@ -1131,10 +1131,11 @@ impl WindowMethods for Window {
         pseudo: Option<DOMString>,
     ) -> DomRoot<CSSStyleDeclaration> {
         // Steps 1-4.
-        let pseudo = match pseudo.map(|mut s| {
+        let pseudo = pseudo.map(|mut s| {
             s.make_ascii_lowercase();
             s
-        }) {
+        });
+        let pseudo = match pseudo {
             Some(ref pseudo) if pseudo == ":before" || pseudo == "::before" => {
                 Some(PseudoElement::Before)
             },