Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-09 15:35:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

wpt: Fix flakiness in vh_not_refreshing_on_chrome.html (#34626)

Browse source 
This test manually animates the height of an `<iframe>` that has content
which uses the `vh` unit. Each tick of the animation changes the height
by one pixel. Inside the `<iframe>` the element using `vh` units has a
transition applied, so every manual tick of the animation triggers a new
transition. The causes a pretty slow test execution.

This change improves `vh_not_refreshing_on_chrome.html` to remove
flakiness by making the test wait to start until after the `<iframe>` has
loaded and to increase the `<iframe>` height by 10 pixels instead of 1
when doing the manual animation. These changes make the test faster and
much less flaky in Servo.

In addition, the test is reformated a bit removing extraneous whitespace
and renamed to follow WPT naming conventions.

Fixes #23385.
Fixes #15570.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2024-12-16 16:46:46 +01:00 • committed by GitHub
parent 3e052676ef
commit a0dce44ce6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 278 additions and 296 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/css/css-values/vh_not_refreshing_on_chrome.html.ini vendored
View file

@ -1,2 +0,0 @@
[vh_not_refreshing_on_chrome.html]
expected: TIMEOUT