Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 05:30:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #13897 - scotttrinh:dom-webidl, r=jdm

Browse source 
Partial fix for #12415: DOM interfaces

<!-- Please describe your changes on the following line: -->
Fix exposure of DOM interfaces. Only two of the interfaces needed changing and I want someone to double check on `DOMException` (which I left exposed to both `Window` and `Worker`), but I used Firefox's definition as my source since the specs don't lay it out explicitly.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix (partially) #12415  (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because they only remove code.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13897)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2016-10-23 12:21:11 -05:00 • committed by GitHub
commit a1306e1dd3
3 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/webidls/DOMStringMap.webidl
View file

@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// https://html.spec.whatwg.org/multipage/#the-domstringmap-interface // https://html.spec.whatwg.org/multipage/#the-domstringmap-interface
[OverrideBuiltins, Exposed=(Window,Worker)] [OverrideBuiltins]
interface DOMStringMap { interface DOMStringMap {
getter DOMString (DOMString name); getter DOMString (DOMString name);
[Throws] [Throws]

1
components/script/dom/webidls/DOMTokenList.webidl
View file

@ -3,7 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// https://dom.spec.whatwg.org/#domtokenlist // https://dom.spec.whatwg.org/#domtokenlist
[Exposed=(Window,Worker)]
interface DOMTokenList { interface DOMTokenList {
[Pure] [Pure]
readonly attribute unsigned long length; readonly attribute unsigned long length;

2
tests/wpt/mozilla/tests/mozilla/interfaces.worker.js
View file

@ -20,8 +20,6 @@ test_interfaces([
"CustomEvent", "CustomEvent",
"DedicatedWorkerGlobalScope", "DedicatedWorkerGlobalScope",
"DOMException", "DOMException",
"DOMTokenList",
"DOMStringMap",
"ErrorEvent", "ErrorEvent",
"Event", "Event",
"EventTarget", "EventTarget",