Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-24 00:54:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

implement HTMLDataListElement.options

Browse source
This commit is contained in:
lpy 2014-03-08 00:32:34 +08:00
parent af616dba58
commit a2189ee066
3 changed files with 27 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/components/script/dom/bindings/codegen/Bindings.conf
View file

@ -138,7 +138,7 @@ addHTMLElement('HTMLBRElement')
addHTMLElement('HTMLCanvasElement') addHTMLElement('HTMLCanvasElement')
addHTMLElement('HTMLDataElement') addHTMLElement('HTMLDataElement')
addHTMLElement('HTMLDivElement') addHTMLElement('HTMLDivElement')
addHTMLElement('HTMLDataListElement') addHTMLElement('HTMLDataListElement', needsAbstract=['options'])
addHTMLElement('HTMLDirectoryElement') addHTMLElement('HTMLDirectoryElement')
addHTMLElement('HTMLDListElement') addHTMLElement('HTMLDListElement')
addHTMLElement('HTMLElement') addHTMLElement('HTMLElement')

12
src/components/script/dom/htmldatalistelement.rs
View file

@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use dom::bindings::codegen::HTMLDataListElementBinding; use dom::bindings::codegen::HTMLDataListElementBinding;
use dom::bindings::codegen::InheritTypes::HTMLDataListElementDerived; use dom::bindings::codegen::InheritTypes::{HTMLDataListElementDerived, NodeCast};
use dom::bindings::js::JS; use dom::bindings::js::JS;
use dom::document::Document; use dom::document::Document;
use dom::element::HTMLDataListElementTypeId; use dom::element::HTMLDataListElementTypeId;
@ -41,10 +41,10 @@ impl HTMLDataListElement {
} }
impl HTMLDataListElement { impl HTMLDataListElement {
pub fn Options(&self) -> JS<HTMLCollection> { pub fn Options(&self, abstract_self: &JS<HTMLDataListElement>) -> JS<HTMLCollection> {
// FIXME: https://github.com/mozilla/servo/issues/1842 let node: JS<Node> = NodeCast::from(abstract_self);
let doc = self.htmlelement.element.node.owner_doc(); let doc = &self.htmlelement.element.node.owner_doc();
let doc = doc.get(); let window = &doc.get().window;
HTMLCollection::new(&doc.window, ~[]) HTMLCollection::by_tag_name(window, &node, ~"option")
} }
} }

20
src/test/content/test_document_datalist_options.html Normal file
View file

@ -0,0 +1,20 @@
<html>
<head>
<script src="harness.js"></script>
</head>
<datalist id="id">
<option value="A">
<option value="B">
<p>P</p>
<div>DIV</div>
<option value="C">
</datalist>
<script>
var datalist = document.getElementById("id");
is(datalist.options.length, 3);
is_a(datalist.options[0], HTMLOptionElement);
is_a(datalist.options[1], HTMLOptionElement);
is_a(datalist.options[2], HTMLOptionElement);
finish();
</script>
</html>