Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

fix: add error handling to BaseAudioContext::new_inherited (#33023)

Browse source 
* fix: add error handling to BaseAudioContext::new_inherited

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

* Update servo-media

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>

* Update test expectations

Signed-off-by: Taym <haddadi.taym@gmail.com>

* Update servo-media

Signed-off-by: Taym <haddadi.taym@gmail.com>

---------

Signed-off-by: Bentaimia Haddadi <haddadi.taym@gmail.com>
Signed-off-by: Taym <haddadi.taym@gmail.com>
This commit is contained in:
Taym Haddadi 2024-08-18 15:58:43 +02:00 • committed by GitHub
parent 1ef3e107bd
commit a24e92778a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 37 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/offlineaudiocontext.rs
View file

@ -51,7 +51,7 @@ impl OfflineAudioContext {
length: u32,
sample_rate: f32,
pipeline_id: PipelineId,
) -> OfflineAudioContext {
) -> Fallible<OfflineAudioContext> {
let options = ServoMediaOfflineAudioContextOptions {
channels: channel_count as u8,
length: length as usize,
@ -60,14 +60,14 @@ impl OfflineAudioContext {
let context = BaseAudioContext::new_inherited(
BaseAudioContextOptions::OfflineAudioContext(options),
pipeline_id,
);
OfflineAudioContext {
)?;
Ok(OfflineAudioContext {
context,
channel_count,
length,
rendering_started: Cell::new(false),
pending_rendering_promise: Default::default(),
}
})
}
#[allow(crown::unrooted_must_root)]
@ -87,7 +87,7 @@ impl OfflineAudioContext {
}
let pipeline_id = window.pipeline_id();
let context =
OfflineAudioContext::new_inherited(channel_count, length, sample_rate, pipeline_id);
OfflineAudioContext::new_inherited(channel_count, length, sample_rate, pipeline_id)?;
Ok(reflect_dom_object_with_proto(
Box::new(context),
window,