Eliminate warnings in util::tree

src/servo/css/resolve/apply.rs

@@ -108,8 +108,8 @@ impl StyleApplicator {
     fn apply_css_style(layout_ctx: &LayoutContext) {
         let reflow = copy self.reflow;
 
-        do NodeTree.each_child(self.node) |child| {
-            inheritance_wrapper(layout_ctx, child, reflow); true
+        do NodeTree.each_child(&self.node) |child| {
+            inheritance_wrapper(layout_ctx, *child, reflow); true
         }
     }
 

src/servo/css/styles.rs

@@ -146,7 +146,7 @@ impl Node : StyleMethods {
         let mut i = 0u;
         
         // Compute the styles of each of our children in parallel
-        for NodeTree.each_child(self) |kid| {
+        for NodeTree.each_child(&self) |kid| {
             i = i + 1u;
             let new_styles = clone(&styles);
             

src/servo/dom/node.rs

@@ -27,8 +27,8 @@ enum NodeData = {
 enum NodeTree { NodeTree }
 
 impl NodeTree : tree::ReadMethods<Node> {
-    fn each_child(node: Node, f: fn(Node) -> bool) {
-        tree::each_child(self, node, f)
+    fn each_child(node: &Node, f: fn(&Node) -> bool) {
+        tree::each_child(&self, node, f)
     }
 
     fn with_tree_fields<R>(&&n: Node, f: fn(tree::Tree<Node>) -> R) -> R {
@@ -39,11 +39,11 @@ impl NodeTree : tree::ReadMethods<Node> {
 impl Node {
     fn traverse_preorder(preorder_cb: &fn(Node)) {
         preorder_cb(self);
-        do NodeTree.each_child(self) |child| { child.traverse_preorder(preorder_cb); true }
+        do NodeTree.each_child(&self) |child| { child.traverse_preorder(preorder_cb); true }
     }
 
     fn traverse_postorder(postorder_cb: &fn(Node)) {
-        do NodeTree.each_child(self) |child| { child.traverse_postorder(postorder_cb); true }
+        do NodeTree.each_child(&self) |child| { child.traverse_postorder(postorder_cb); true }
         postorder_cb(self);
     }
 }
@@ -77,7 +77,7 @@ impl Node : DebugMethods {
         s += self.debug_str();
         debug!("%s", s);
 
-        for NodeTree.each_child(*self) |kid| {
+        for NodeTree.each_child(self) |kid| {
             kid.dump_indent(indent + 1u) 
         }
     }
@@ -153,12 +153,12 @@ impl NodeScope : NodeScopeExtensions {
 
 #[allow(non_implicitly_copyable_typarams)]
 impl NodeScope : tree::ReadMethods<Node> {
-    fn each_child(node: Node, f: fn(Node) -> bool) {
-        tree::each_child(self, node, f)
+    fn each_child(node: &Node, f: fn(&Node) -> bool) {
+        tree::each_child(&self, node, f)
     }
 
-    fn get_parent(node: Node) -> Option<Node> {
-        tree::get_parent(self, node)
+    fn get_parent(node: &Node) -> Option<Node> {
+        tree::get_parent(&self, node)
     }
 
     fn with_tree_fields<R>(node: Node, f: fn(tree::Tree<Node>) -> R) -> R {
@@ -168,8 +168,8 @@ impl NodeScope : tree::ReadMethods<Node> {
 
 #[allow(non_implicitly_copyable_typarams)]
 impl NodeScope : tree::WriteMethods<Node> {
-    fn add_child(node: Node, child: Node) {
-        tree::add_child(self, node, child)
+    fn add_child(+node: Node, +child: Node) {
+        tree::add_child(&self, node, child)
     }
 
     fn with_tree_fields<R>(node: Node, f: fn(tree::Tree<Node>) -> R) -> R {

src/servo/layout/box.rs

@@ -304,8 +304,8 @@ trait ImageBoxMethods {
 pub enum RenderBoxTree { RenderBoxTree }
 
 impl RenderBoxTree : tree::ReadMethods<@RenderBox> {
-    fn each_child(node: @RenderBox, f: fn(&&box: @RenderBox) -> bool) {
-        tree::each_child(self, node, f)
+    fn each_child(node: @RenderBox, f: fn(box: @RenderBox) -> bool) {
+        tree::each_child(&self, &node, |box| f(*box) )
     }
 
     fn with_tree_fields<R>(&&b: @RenderBox, f: fn(tree::Tree<@RenderBox>) -> R) -> R {
@@ -316,7 +316,7 @@ impl RenderBoxTree : tree::ReadMethods<@RenderBox> {
 impl RenderBoxTree : tree::WriteMethods<@RenderBox> {
     fn add_child(parent: @RenderBox, child: @RenderBox) {
         assert !core::box::ptr_eq(parent, child);
-        tree::add_child(self, parent, child)
+        tree::add_child(&self, parent, child)
     }
 
     fn with_tree_fields<R>(&&b: @RenderBox, f: fn(tree::Tree<@RenderBox>) -> R) -> R {
@@ -384,8 +384,8 @@ mod test {
 
     fn flat_bounds(root: @RenderBox) -> ~[Rect<au>] {
         let mut r = ~[];
-        for tree::each_child(RenderBoxTree, root) |c| {
-            push_all(&mut r, flat_bounds(c));
+        for tree::each_child(&RenderBoxTree, &root) |c| {
+            push_all(&mut r, flat_bounds(*c));
         }
 
         push(&mut r, copy root.d().position);

src/servo/layout/box_builder.rs

@@ -126,8 +126,8 @@ impl LayoutTreeBuilder {
         }
         // recurse
         // TODO: don't set parent box unless this is an inline flow?
-        do NodeTree.each_child(cur_node) |child_node| {
-            self.construct_recursively(layout_ctx, child_node, next_ctx, Some(new_box)); true
+        do NodeTree.each_child(&cur_node) |child_node| {
+            self.construct_recursively(layout_ctx, *child_node, next_ctx, Some(new_box)); true
         }
 
         // Fixup any irregularities, such as split inlines (CSS 2.1 Section 9.2.1.1)

src/servo/layout/flow.rs

@@ -213,8 +213,8 @@ impl FlowContext {
 enum FlowTree { FlowTree }
 
 impl FlowTree : tree::ReadMethods<@FlowContext> {
-    fn each_child(ctx: @FlowContext, f: fn(&&box: @FlowContext) -> bool) {
-        tree::each_child(self, ctx, f)
+    fn each_child(ctx: @FlowContext, f: fn(box: @FlowContext) -> bool) {
+        tree::each_child(&self, &ctx, |box| f(*box) )
     }
 
     fn with_tree_fields<R>(&&box: @FlowContext, f: fn(tree::Tree<@FlowContext>) -> R) -> R {
@@ -225,7 +225,7 @@ impl FlowTree : tree::ReadMethods<@FlowContext> {
 impl FlowTree : tree::WriteMethods<@FlowContext> {
     fn add_child(parent: @FlowContext, child: @FlowContext) {
         assert !core::box::ptr_eq(parent, child);
-        tree::add_child(self, parent, child)
+        tree::add_child(&self, parent, child)
     }
 
     fn with_tree_fields<R>(&&box: @FlowContext, f: fn(tree::Tree<@FlowContext>) -> R) -> R {

src/servo/util/color.rs

@@ -69,13 +69,13 @@ impl Color {
 mod parsing {
     export parse_color;
 
-    fn fail_unrecognized(col : ~str) -> Option<Color> {
+    fn fail_unrecognized(col : &str) -> Option<Color> {
         warn!("Unrecognized color %s", col);
         return None;
     }
 
     /** Match an exact color keyword. */
-    fn parse_by_name(color : ~str) -> Option<Color> {
+    fn parse_by_name(color : &str) -> Option<Color> {
         let col = match color.to_lower() {
           ~"black" => black(),
           ~"silver" => silver(),
@@ -101,7 +101,7 @@ mod parsing {
     }
     
     /** Parses a color specification in the form rgb(foo,bar,baz) */
-    fn parse_rgb(color : ~str) -> Option<Color> {
+    fn parse_rgb(color : &str) -> Option<Color> {
         // Shave off the rgb( and the )
         let only_colors = color.substr(4u, color.len() - 5u);
 
@@ -117,7 +117,7 @@ mod parsing {
     }
 
     /** Parses a color specification in the form rgba(foo,bar,baz,qux) */
-    fn parse_rgba(color : ~str) -> Option<Color> {
+    fn parse_rgba(color : &str) -> Option<Color> {
         // Shave off the rgba( and the )
         let only_vals = color.substr(5u, color.len() - 6u);
 
@@ -133,7 +133,7 @@ mod parsing {
     }
 
     /** Parses a color specification in the form hsl(foo,bar,baz) */
-    fn parse_hsl(color : ~str) -> Option<Color> {
+    fn parse_hsl(color : &str) -> Option<Color> {
         // Shave off the hsl( and the )
         let only_vals = color.substr(4u, color.len() - 5u);
 
@@ -149,7 +149,7 @@ mod parsing {
     }
 
     /** Parses a color specification in the form hsla(foo,bar,baz,qux) */
-    fn parse_hsla(color : ~str) -> Option<Color> {
+    fn parse_hsla(color : &str) -> Option<Color> {
         // Shave off the hsla( and the )
         let only_vals = color.substr(5u, color.len() - 6u);
 
@@ -166,12 +166,12 @@ mod parsing {
     // Currently colors are supported in rgb(a,b,c) form and also by
     // keywords for several common colors.
     // TODO: extend this
-    fn parse_color(color : ~str) -> Option<Color> {
+    fn parse_color(color : &str) -> Option<Color> {
         match color {
-          c if c.starts_with(~"rgb(") => parse_rgb(c),
-          c if c.starts_with(~"rgba(") => parse_rgba(c),
-          c if c.starts_with(~"hsl(") => parse_hsl(c),
-          c if c.starts_with(~"hsla(") => parse_hsla(c),
+          c if c.starts_with("rgb(") => parse_rgb(c),
+          c if c.starts_with("rgba(") => parse_rgba(c),
+          c if c.starts_with("hsl(") => parse_hsl(c),
+          c if c.starts_with("hsla(") => parse_hsla(c),
           c => parse_by_name(c)
         }
     }

src/servo/util/tree.rs

@@ -20,14 +20,14 @@ pub trait WriteMethods<T> {
     fn with_tree_fields<R>(T, f: fn(Tree<T>) -> R) -> R;
 }
 
-pub fn each_child<T:Copy,O:ReadMethods<T>>(ops: O, node: T, f: fn(T) -> bool) {
-    let mut p = ops.with_tree_fields(node, |f| f.first_child);
+pub fn each_child<T:Copy,O:ReadMethods<T>>(ops: &O, node: &T, f: fn(&T) -> bool) {
+    let mut p = ops.with_tree_fields(*node, |f| f.first_child);
     loop {
         match copy p {
           None => { return; }
-          Some(c) => {
+          Some(ref c) => {
             if !f(c) { return; }
-            p = ops.with_tree_fields(c, |f| f.next_sibling);
+            p = ops.with_tree_fields(*c, |f| f.next_sibling);
           }
         }
     }
@@ -41,7 +41,7 @@ pub fn empty<T>() -> Tree<T> {
      mut next_sibling: None}
 }
 
-pub fn add_child<T:Copy,O:WriteMethods<T>>(ops: O, parent: T, child: T) {
+pub fn add_child<T:Copy,O:WriteMethods<T>>(ops: &O, +parent: T, +child: T) {
 
     ops.with_tree_fields(child, |child_tf| {
         match child_tf.parent {
@@ -72,8 +72,8 @@ pub fn add_child<T:Copy,O:WriteMethods<T>>(ops: O, parent: T, child: T) {
     });
 }
 
-pub fn get_parent<T:Copy,O:ReadMethods<T>>(ops: O, node: T) -> Option<T> {
-    ops.with_tree_fields(node, |tf| tf.parent)
+pub fn get_parent<T:Copy,O:ReadMethods<T>>(ops: &O, node: &T) -> Option<T> {
+    ops.with_tree_fields(*node, |tf| tf.parent)
 }
 
 #[cfg(test)]
@@ -108,7 +108,7 @@ mod test {
         let p = new_dummy(3u);
 
         for vec::each(children) |c| {
-            add_child(dtree, p, *c);
+            add_child(&dtree, p, *c);
         }
 
         return {p: p, children: children};
@@ -118,7 +118,7 @@ mod test {
     fn add_child_0() {
         let {p, children} = parent_with_3_children();
         let mut i = 0u;
-        for each_child(dtree, p) |c| {
+        for each_child(&dtree, &p) |c| {
             assert c.value == i;
             i += 1u;
         }
@@ -129,7 +129,7 @@ mod test {
     fn add_child_break() {
         let {p, _} = parent_with_3_children();
         let mut i = 0u;
-        for each_child(dtree, p) |_c| {
+        for each_child(&dtree, &p) |_c| {
             i += 1u;
             break;
         }