Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Make text-orientation, unicode-bidi, contain and will-change non-animatable.

Browse source 
Per recent CSSWG resolutions:

  https://github.com/w3c/csswg-drafts/issues/2737
  https://github.com/w3c/csswg-drafts/issues/2751

Differential Revision: https://phabricator.services.mozilla.com/D3888
This commit is contained in:
Emilio Cobos Álvarez 2018-08-21 16:42:27 +02:00
parent e338bd3add
commit a2d6566d0b
No known key found for this signature in database
GPG key ID: 056B727BB9C1027C
3 changed files with 19 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/style/properties/longhands/box.mako.rs
View file

@ -513,14 +513,16 @@ ${helpers.predefined_type(
servo_restyle_damage="reflow_out_of_flow" servo_restyle_damage="reflow_out_of_flow"
)} )}
${helpers.predefined_type("contain", ${helpers.predefined_type(
"contain",
"Contain", "Contain",
"specified::Contain::empty()", "specified::Contain::empty()",
animation_value_type="discrete", animation_value_type="none",
products="gecko", products="gecko",
flags="CREATES_STACKING_CONTEXT FIXPOS_CB", flags="CREATES_STACKING_CONTEXT FIXPOS_CB",
gecko_pref="layout.css.contain.enabled", gecko_pref="layout.css.contain.enabled",
spec="https://drafts.csswg.org/css-contain/#contain-property")} spec="https://drafts.csswg.org/css-contain/#contain-property",
)}
// Non-standard // Non-standard
${helpers.predefined_type( ${helpers.predefined_type(
@ -552,7 +554,7 @@ ${helpers.predefined_type(
"WillChange", "WillChange",
"computed::WillChange::auto()", "computed::WillChange::auto()",
products="gecko", products="gecko",
animation_value_type="discrete", animation_value_type="none",
spec="https://drafts.csswg.org/css-will-change/#will-change" spec="https://drafts.csswg.org/css-will-change/#will-change"
)} )}

5
components/style/properties/longhands/inherited_box.mako.rs
View file

@ -40,15 +40,12 @@ ${helpers.single_keyword(
servo_restyle_damage="rebuild_and_reflow", servo_restyle_damage="rebuild_and_reflow",
)} )}
// TODO(emilio): Should text-orientation be non-animatable? It affects the
// WritingMode value, but not the logical -> physical mapping of properties,
// which is the reason direction / writing-mode are non-animatable.
${helpers.single_keyword( ${helpers.single_keyword(
"text-orientation", "text-orientation",
"mixed upright sideways", "mixed upright sideways",
extra_gecko_aliases="sideways-right=sideways", extra_gecko_aliases="sideways-right=sideways",
products="gecko", products="gecko",
animation_value_type="discrete", animation_value_type="none",
spec="https://drafts.csswg.org/css-writing-modes/#propdef-text-orientation", spec="https://drafts.csswg.org/css-writing-modes/#propdef-text-orientation",
)} )}

8
components/style/properties/longhands/text.mako.rs
View file

@ -21,11 +21,13 @@ ${helpers.predefined_type("text-overflow",
spec="https://drafts.csswg.org/css-ui/#propdef-text-overflow", spec="https://drafts.csswg.org/css-ui/#propdef-text-overflow",
servo_restyle_damage="rebuild_and_reflow")} servo_restyle_damage="rebuild_and_reflow")}
${helpers.single_keyword("unicode-bidi", ${helpers.single_keyword(
"unicode-bidi",
"normal embed isolate bidi-override isolate-override plaintext", "normal embed isolate bidi-override isolate-override plaintext",
animation_value_type="discrete", animation_value_type="none",
spec="https://drafts.csswg.org/css-writing-modes/#propdef-unicode-bidi", spec="https://drafts.csswg.org/css-writing-modes/#propdef-unicode-bidi",
servo_restyle_damage="rebuild_and_reflow")} servo_restyle_damage="rebuild_and_reflow",
)}
${helpers.predefined_type("text-decoration-line", ${helpers.predefined_type("text-decoration-line",
"TextDecorationLine", "TextDecorationLine",