Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #24672 - paulrouget:24400, r=jdm

Browse source 
Print an error if Glutin port needs to manage a new tab

When a tab needs to be created because the user clicks on a link with a `target=…` attribute, the Glutin port just ignores it, creating weird behaviors.

We should at least print an error.
This commit is contained in:
bors-servo 2019-11-07 02:38:26 -05:00 • committed by GitHub
commit a33d493a4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ports/glutin/browser.rs
View file

@ -346,6 +346,8 @@ where
self.browsers.push(new_browser_id); self.browsers.push(new_browser_id);
if self.browser_id.is_none() { if self.browser_id.is_none() {
self.browser_id = Some(new_browser_id); self.browser_id = Some(new_browser_id);
} else {
error!("Multiple top level browsing contexts not supported yet.");
} }
self.event_queue self.event_queue
.push(WindowEvent::SelectBrowser(new_browser_id)); .push(WindowEvent::SelectBrowser(new_browser_id));