From d81c44335f93748046a148cb8897d1709579e4d1 Mon Sep 17 00:00:00 2001 From: Josh Mcguigan Date: Wed, 30 Oct 2019 20:41:32 -0700 Subject: [PATCH 1/2] PerformanceResourceTiming calculate duration --- components/script/dom/performanceresourcetiming.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/components/script/dom/performanceresourcetiming.rs b/components/script/dom/performanceresourcetiming.rs index 735d13a31f4..586515d4365 100644 --- a/components/script/dom/performanceresourcetiming.rs +++ b/components/script/dom/performanceresourcetiming.rs @@ -55,7 +55,6 @@ pub struct PerformanceResourceTiming { decoded_body_size: u64, //size in octets } -// TODO(#21255): duration // TODO(#21269): next_hop // TODO(#21264): worker_start // TODO(#21258): fetch_start @@ -115,7 +114,7 @@ impl PerformanceResourceTiming { DOMString::from(url.into_string()), DOMString::from("resource"), resource_timing.start_time as f64, - 0., + resource_timing.response_end as f64 - resource_timing.start_time as f64, ), initiator_type: initiator_type, next_hop: next_hop, From 72702b728470c409a9b6082c50e7ad5be98f9728 Mon Sep 17 00:00:00 2001 From: Josh Mcguigan Date: Thu, 31 Oct 2019 17:55:38 -0700 Subject: [PATCH 2/2] update test resource timing tests --- .../wpt/metadata/resource-timing/test_resource_timing.html.ini | 3 --- .../resource-timing/test_resource_timing.https.html.ini | 3 --- 2 files changed, 6 deletions(-) diff --git a/tests/wpt/metadata/resource-timing/test_resource_timing.html.ini b/tests/wpt/metadata/resource-timing/test_resource_timing.html.ini index 32bb07949a1..918016b21b8 100644 --- a/tests/wpt/metadata/resource-timing/test_resource_timing.html.ini +++ b/tests/wpt/metadata/resource-timing/test_resource_timing.html.ini @@ -15,9 +15,6 @@ [PerformanceEntry has correct protocol attribute (iframe)] expected: FAIL - [PerformanceEntry has correct name, initiatorType, startTime, and duration (img)] - expected: FAIL - [PerformanceEntry has correct order of timing attributes (img)] expected: FAIL diff --git a/tests/wpt/metadata/resource-timing/test_resource_timing.https.html.ini b/tests/wpt/metadata/resource-timing/test_resource_timing.https.html.ini index 59f26282158..0baf5d404c2 100644 --- a/tests/wpt/metadata/resource-timing/test_resource_timing.https.html.ini +++ b/tests/wpt/metadata/resource-timing/test_resource_timing.https.html.ini @@ -66,9 +66,6 @@ [PerformanceEntry has correct protocol attribute (script)] expected: FAIL - [PerformanceEntry has correct name, initiatorType, startTime, and duration (img)] - expected: FAIL - [PerformanceEntry has correct name, initiatorType, startTime, and duration (link)] expected: NOTRUN