Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Webdriver: Send Keys use webview::notify_input_event (#37911)

Browse source 
Previously, we SendKeys will be forwarded to constellation by the
embedder. Now we use webview.notify_input_event, which will send
WebDriverCommandMsg::ForwardInputEvent for the KeyboardEvent and
CompositionEvent.

Fixes: part of https://github.com/servo/servo/issues/37370

---------

Signed-off-by: PotatoCP <kenzieradityatirtarahardja18@gmail.com>
This commit is contained in:
Kenzie Raditya Tirtarahardja 2025-07-10 20:37:01 +08:00 • committed by GitHub
parent f88dd2a12c
commit a475175949
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 32 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

12
components/webdriver_server/lib.rs
View file

@ -1842,20 +1842,15 @@ impl Handler {
element: &WebElement,
keys: &SendKeysParameters,
) -> WebDriverResult<WebDriverResponse> {
let browsing_context_id = self.session()?.browsing_context_id;
// Step 3. If session's current browsing context is no longer open,
// return error with error code no such window.
self.verify_browsing_context_is_open(browsing_context_id)?;
// Step 3-8
let (sender, receiver) = ipc::channel().unwrap();
let cmd = WebDriverScriptCommand::WillSendKeys(
element.to_string(),
keys.text.to_string(),
self.session()?.strict_file_interactability,
sender,
);
let cmd_msg = WebDriverCommandMsg::ScriptCommand(browsing_context_id, cmd);
self.send_message_to_embedder(cmd_msg)?;
self.browsing_context_script_command(cmd, VerifyBrowsingContextIsOpen::Yes)?;
// TODO: distinguish the not found and not focusable cases
// File input and non-typeable form control should have
@ -1869,7 +1864,8 @@ impl Handler {
// TODO: there's a race condition caused by the focus command and the
// send keys command being two separate messages,
// so the constellation may have changed state between them.
let cmd_msg = WebDriverCommandMsg::SendKeys(browsing_context_id, input_events);
// TODO: We should use `dispatch_action` to send the keys.
let cmd_msg = WebDriverCommandMsg::SendKeys(self.session()?.webview_id, input_events);
self.send_message_to_embedder(cmd_msg)?;
Ok(WebDriverResponse::Void)