From a4e687aedd6e276bf9e84430457698bc30fa52cf Mon Sep 17 00:00:00 2001 From: Hiroyuki Ikezoe Date: Thu, 4 Jan 2018 19:23:42 +0900 Subject: [PATCH] Drop animation-name and transition-property from early properties We don't need to calculate computed animation-name or transition-property prior to other properties any more because we no longer fill out those other properties values in response to animation-name or transition-property length at the time when we calculate computed property values. --- components/style/properties/properties.mako.rs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/components/style/properties/properties.mako.rs b/components/style/properties/properties.mako.rs index 12750e33b2a..3dd4c6279b5 100644 --- a/components/style/properties/properties.mako.rs +++ b/components/style/properties/properties.mako.rs @@ -687,14 +687,6 @@ impl LonghandId { fn is_early_property(&self) -> bool { matches!(*self, % if product == 'gecko': - // We need to know the number of animations / transition-properties - // before setting the rest of the related longhands, see #15923. - // - // FIXME(emilio): Looks to me that we could just do this in Gecko - // instead of making them early properties. Indeed, the spec - // mentions _used_ values, not computed values, so this looks wrong. - LonghandId::AnimationName | - LonghandId::TransitionProperty | // Needed to properly compute the writing mode, to resolve logical // properties, and similar stuff. In this block instead of along