Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 14:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #17835 - KiChjang:clearer-network-error, r=emilio

Browse source 
Make network error messages more specific

Instead of having a bogus "Network error" string, we extract the NetworkError struct from the Response and send it back to FetchResponseListener.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17835)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-07-24 03:07:26 -07:00 • committed by GitHub
commit a56bd4663b
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/net_traits/lib.rs
View file

@ -228,10 +228,8 @@ impl FetchTaskTarget for IpcSender<FetchResponseMsg> {
} }
fn process_response_eof(&mut self, response: &Response) { fn process_response_eof(&mut self, response: &Response) {
if response.is_network_error() { if let Some(e) = response.get_network_error() {
// todo: finer grained errors let _ = self.send(FetchResponseMsg::ProcessResponseEOF(Err(e.clone())));
let _ =
self.send(FetchResponseMsg::ProcessResponseEOF(Err(NetworkError::Internal("Network error".into()))));
} else { } else {
let _ = self.send(FetchResponseMsg::ProcessResponseEOF(Ok(()))); let _ = self.send(FetchResponseMsg::ProcessResponseEOF(Ok(())));
} }