Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

CanGc fixes through focusevent.rs & hashchangeevent.rs (#33921)

Browse source 
Signed-off-by: taniishkaaa <tanishkasingh2004@gmail.com>
This commit is contained in:
tanishka 2024-10-20 13:35:11 +05:30 • committed by GitHub
parent d0d02cd56c
commit a57b6a3f79
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
20 changed files with 140 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/element.rs
View file

@ -2002,7 +2002,7 @@ impl Element {
}
}
pub(crate) fn update_sequentially_focusable_status(&self) {
pub(crate) fn update_sequentially_focusable_status(&self, can_gc: CanGc) {
let node = self.upcast::<Node>();
let is_sequentially_focusable = self.is_sequentially_focusable();
node.set_flag(NodeFlags::SEQUENTIALLY_FOCUSABLE, is_sequentially_focusable);
@ -2010,7 +2010,7 @@ impl Element {
// https://html.spec.whatwg.org/multipage/#focus-fixup-rule
if !is_sequentially_focusable {
let document = document_from_node(self);
document.perform_focus_fixup_rule(self);
document.perform_focus_fixup_rule(self, can_gc);
}
}
@ -3327,7 +3327,7 @@ impl VirtualMethods for Element {
let doc = node.owner_doc();
match attr.local_name() {
&local_name!("tabindex") | &local_name!("draggable") | &local_name!("hidden") => {
self.update_sequentially_focusable_status()
self.update_sequentially_focusable_status(CanGc::note())
},
&local_name!("style") => {
// Modifying the `style` attribute might change style.
@ -3493,7 +3493,7 @@ impl VirtualMethods for Element {
return;
}
self.update_sequentially_focusable_status();
self.update_sequentially_focusable_status(CanGc::note());
if let Some(ref id) = *self.id_attribute.borrow() {
if let Some(shadow_root) = self.upcast::<Node>().containing_shadow_root() {
@ -3526,7 +3526,7 @@ impl VirtualMethods for Element {
return;
}
self.update_sequentially_focusable_status();
self.update_sequentially_focusable_status(CanGc::note());
let doc = document_from_node(self);