Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

net: Stop using legacy time in the HTTP and CORS caches (#33259)

Browse source 
This is part of switching away from using a very old version of `time`.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2024-08-30 14:54:02 +02:00 • committed by GitHub
parent 817a91f2ac
commit a58d816319
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 53 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

19
components/net/fetch/cors_cache.rs
View file

@ -9,11 +9,12 @@
//! This library will eventually become the core of the Fetch crate
//! with CORSRequest being expanded into FetchRequest (etc)
use std::time::{Duration, Instant};
use http::header::HeaderName;
use http::Method;
use net_traits::request::{CredentialsMode, Origin, Request};
use servo_url::ServoUrl;
use time::{self, Timespec};
/// Union type for CORS cache entries
///
@ -45,17 +46,17 @@ impl HeaderOrMethod {
pub struct CorsCacheEntry {
pub origin: Origin,
pub url: ServoUrl,
pub max_age: u32,
pub max_age: Duration,
pub credentials: bool,
pub header_or_method: HeaderOrMethod,
created: Timespec,
created: Instant,
}
impl CorsCacheEntry {
fn new(
origin: Origin,
url: ServoUrl,
max_age: u32,
max_age: Duration,
credentials: bool,
header_or_method: HeaderOrMethod,
) -> CorsCacheEntry {
@ -65,7 +66,7 @@ impl CorsCacheEntry {
max_age,
credentials,
header_or_method,
created: time::now().to_timespec(),
created: Instant::now(),
}
}
}
@ -107,10 +108,10 @@ impl CorsCache {
/// Remove old entries
pub fn cleanup(&mut self) {
let CorsCache(buf) = self.clone();
let now = time::now().to_timespec();
let now = Instant::now();
let new_buf: Vec<CorsCacheEntry> = buf
.into_iter()
.filter(|e| now.sec < e.created.sec + e.max_age as i64)
.filter(|e| now < e.created + e.max_age)
.collect();
*self = CorsCache(new_buf);
}
@ -129,7 +130,7 @@ impl CorsCache {
&mut self,
request: &Request,
header_name: &HeaderName,
new_max_age: u32,
new_max_age: Duration,
) -> bool {
match self
.find_entry_by_header(request, header_name)
@ -163,7 +164,7 @@ impl CorsCache {
&mut self,
request: &Request,
method: Method,
new_max_age: u32,
new_max_age: Duration,
) -> bool {
match self
.find_entry_by_method(request, method.clone())