Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-18 19:08:22 +01:00
Code Issues Projects Releases Packages Wiki Activity

script: Replace DomRefCell<bool> with Cell<bool> for Response::redirected (#39351)

Browse source 
Replace DomRefCell<bool> with Cell<bool> for Response::redirected field.

Changed redirected field from DomRefCell<bool> to Cell<bool> and updated
all related methods:
- Struct field: redirected: DomRefCell<bool> → redirected: Cell<bool>
- Constructor: DomRefCell::new(false) → Cell::new(false)
- Getter method: *self.redirected.borrow() → self.redirected.get()
- Setter method: *self.redirected.borrow_mut() = value →
self.redirected.set(value)

Testing: As noted in the issue, compilation is sufficient for this
change.

Fixes: #39288

Signed-off-by: ritoban23 <ankudutt101@gmail.com>
This commit is contained in:
Ritoban Dutta 2025-09-18 20:42:55 +05:30 • committed by GitHub
parent af7de5ccf1
commit a5c584f72a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
components/script/dom/response.rs
View file

@ -48,7 +48,7 @@ pub(crate) struct Response {
body_stream: MutNullableDom<ReadableStream>, body_stream: MutNullableDom<ReadableStream>,
#[ignore_malloc_size_of = "StreamConsumer"] #[ignore_malloc_size_of = "StreamConsumer"]
stream_consumer: DomRefCell<Option<StreamConsumer>>, stream_consumer: DomRefCell<Option<StreamConsumer>>,
redirected: DomRefCell<bool>, redirected: Cell<bool>,
is_body_empty: Cell<bool>, is_body_empty: Cell<bool>,
} }
@ -70,7 +70,7 @@ impl Response {
url_list: DomRefCell::new(vec![]), url_list: DomRefCell::new(vec![]),
body_stream: MutNullableDom::new(Some(&*stream)), body_stream: MutNullableDom::new(Some(&*stream)),
stream_consumer: DomRefCell::new(None), stream_consumer: DomRefCell::new(None),
redirected: DomRefCell::new(false), redirected: Cell::new(false),
is_body_empty: Cell::new(true), is_body_empty: Cell::new(true),
} }
} }
@ -273,7 +273,7 @@ impl ResponseMethods<crate::DomTypeHolder> for Response {
/// <https://fetch.spec.whatwg.org/#dom-response-redirected> /// <https://fetch.spec.whatwg.org/#dom-response-redirected>
fn Redirected(&self) -> bool { fn Redirected(&self) -> bool {
return *self.redirected.borrow(); self.redirected.get()
} }
/// <https://fetch.spec.whatwg.org/#dom-response-status> /// <https://fetch.spec.whatwg.org/#dom-response-status>
@ -487,7 +487,7 @@ impl Response {
} }
pub(crate) fn set_redirected(&self, is_redirected: bool) { pub(crate) fn set_redirected(&self, is_redirected: bool) {
*self.redirected.borrow_mut() = is_redirected; self.redirected.set(is_redirected);
} }
fn set_response_members_by_type(&self, response_type: DOMResponseType, can_gc: CanGc) { fn set_response_members_by_type(&self, response_type: DOMResponseType, can_gc: CanGc) {