From a646c850c6f7dcaf64ad286342b654ffdbebd274 Mon Sep 17 00:00:00 2001 From: tanishka <109246904+taniishkaaa@users.noreply.github.com> Date: Wed, 16 Oct 2024 21:04:14 +0530 Subject: [PATCH] clippy: Fix warnings in `components/script/dom` & `components/servo` (#33853) * clippy: Fix warnings in components/script/dom & components/servo Signed-off-by: taniishkaaa * Move allow to the level of the named field Signed-off-by: taniishkaaa * Add blank lines before & after field Signed-off-by: taniishkaaa * remove trailing whitespace Signed-off-by: Mukilan Thiyagarajan --------- Signed-off-by: taniishkaaa Signed-off-by: Mukilan Thiyagarajan Co-authored-by: Mukilan Thiyagarajan --- components/script/dom/htmlformelement.rs | 3 +++ components/script/dom/htmlmediaelement.rs | 1 + components/servo/lib.rs | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/components/script/dom/htmlformelement.rs b/components/script/dom/htmlformelement.rs index 9125a14deec..105cbf74ebe 100644 --- a/components/script/dom/htmlformelement.rs +++ b/components/script/dom/htmlformelement.rs @@ -97,7 +97,10 @@ pub struct HTMLFormElement { elements: DomOnceCell, generation_id: Cell, controls: DomRefCell>>, + + #[allow(clippy::type_complexity)] past_names_map: DomRefCell, NoTrace)>>, + firing_submission_events: Cell, rel_list: MutNullableDom, diff --git a/components/script/dom/htmlmediaelement.rs b/components/script/dom/htmlmediaelement.rs index 82bffc1b4d0..234122bfe0c 100644 --- a/components/script/dom/htmlmediaelement.rs +++ b/components/script/dom/htmlmediaelement.rs @@ -344,6 +344,7 @@ pub struct HTMLMediaElement { #[ignore_malloc_size_of = "promises are hard"] pending_play_promises: DomRefCell>>, /// Play promises which are soon to be fulfilled by a queued task. + #[allow(clippy::type_complexity)] #[ignore_malloc_size_of = "promises are hard"] in_flight_play_promises_queue: DomRefCell]>, ErrorResult)>>, #[ignore_malloc_size_of = "servo_media"] diff --git a/components/servo/lib.rs b/components/servo/lib.rs index 0ea81be7274..9407f13f965 100644 --- a/components/servo/lib.rs +++ b/components/servo/lib.rs @@ -993,7 +993,7 @@ fn create_compositor_channel( ROUTER.add_route( compositor_ipc_receiver.to_opaque(), Box::new(move |message| { - let _ = compositor_proxy_clone.send(CompositorMsg::CrossProcess( + compositor_proxy_clone.send(CompositorMsg::CrossProcess( message.to().expect("Could not convert Compositor message"), )); }),