From a6b27c5078eb8c34cbd83ddce1566ed068c3eca0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20W=C3=BClker?= Date: Fri, 4 Jul 2025 09:10:06 +0200 Subject: [PATCH] Don't increment node revision twice when attaching shadow root to element (#37865) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `Node::dirty` already increments the version. `Node::rev_version` traverses all ancestors, so it can end up being fairly expensive. Testing: I'm not sure about WPT coverage but I think this change is trivial enough to merge without tests. Signed-off-by: Simon Wülker --- components/script/dom/element.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/components/script/dom/element.rs b/components/script/dom/element.rs index 881f8c04edd..bc43471686c 100644 --- a/components/script/dom/element.rs +++ b/components/script/dom/element.rs @@ -683,7 +683,6 @@ impl Element { let node = self.upcast::(); node.dirty(NodeDamage::Other); - node.rev_version(); Ok(shadow_root) }