From a77ee1521aaf0a8728ee88695958946b7ac33632 Mon Sep 17 00:00:00 2001 From: Astraea Quinn S <52372765+PartiallyUntyped@users.noreply.github.com> Date: Mon, 5 May 2025 18:51:11 +0200 Subject: [PATCH] Fix missing user-agent from servo-shell (#36859) Properly passes user-agent from servoshell args to the preferences. Testing: ```bash RUST_LOG=warn WAYLAND_DISPLAY='' ./mach run -r --screen-size=375x812 --window-size=375x812 --pref=dom_svg_enabled --pref=dom_intersection_observer_enabled --user-agent "Mozilla/5.0 (iPhone; CPU iPhone OS 14_6 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.0.3 Mobile/15E148 Safari/604.1" RUST_LOG=warn WAYLAND_DISPLAY='' ./mach run -r --screen-size=375x812 --window-size=375x812 --pref=dom_svg_enabled --pref=dom_intersection_observer_enabled ``` Fixes: N/A --------- Signed-off-by: Astraea Quinn Skoutelli Signed-off-by: Martin Robinson Co-authored-by: Martin Robinson --- ports/servoshell/prefs.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ports/servoshell/prefs.rs b/ports/servoshell/prefs.rs index 7eae7a3850c..306aaa197d2 100644 --- a/ports/servoshell/prefs.rs +++ b/ports/servoshell/prefs.rs @@ -653,6 +653,10 @@ pub(crate) fn parse_command_line_arguments(args: Vec) -> ArgumentParsing preferences.media_glvideo_enabled = false; } + if let Some(user_agent) = opt_match.opt_str("user-agent") { + preferences.user_agent = user_agent; + } + let opts = Opts { debug: debug_options.clone(), wait_for_stable_image,