From a7b5ba14c0f1e8a3167fd21ca5b1916dd2220a9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Fri, 2 Nov 2018 18:19:06 +0000 Subject: [PATCH] style: Use references in the shapes code. It doesn't make much sense to return const UniquePtr& for something that can't be null, it's just confusing. Also make more stuff actually const. Differential Revision: https://phabricator.services.mozilla.com/D10647 --- components/style/gecko/conversions.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/style/gecko/conversions.rs b/components/style/gecko/conversions.rs index 6a2287dc033..eeb13fce732 100644 --- a/components/style/gecko/conversions.rs +++ b/components/style/gecko/conversions.rs @@ -718,7 +718,7 @@ pub mod basic_shape { match other.mType { StyleShapeSourceType::URL => unsafe { let shape_image = &*other.__bindgen_anon_1.mShapeImage.as_ref().mPtr; - let other_url = RefPtr::new(*shape_image.__bindgen_anon_1.mURLValue.as_ref()); + let other_url = RefPtr::new(*shape_image.__bindgen_anon_1.mURLValue.as_ref() as *mut _); let url = ComputedUrl::from_url_value(other_url); ShapeSource::ImageOrUrl(url) },