Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

auto merge of #836 : bfrohs/servo/834upperTagName, r=jdm

Browse source 
http://dom.spec.whatwg.org/#dom-element-tagname

I added `window.alert(elem.tagName);` to line 14 of `test_bindings.js` to test (segfault at line 17), and it indeed uppercased the tagName. I didn't add that to this commit, however, because `tagName` is already tested on line 50 of that file. I'm assuming the duplication isn't necessary. Am I correct in that assumption? Or should tests be added somewhere for this? Where?
This commit is contained in:
bors-servo 2013-09-03 09:46:03 -07:00
commit a8718d77f1
3 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/components/script/dom/element.rs
View file

@ -19,6 +19,7 @@ use js::jsapi::{JSContext, JSObject};
use std::cell::Cell; use std::cell::Cell;
use std::comm; use std::comm;
use std::str::eq_slice; use std::str::eq_slice;
use std::ascii::StrAsciiExt;
use std::FromStr; use std::FromStr;
pub struct Element { pub struct Element {
@ -171,7 +172,7 @@ impl<'self> Element {
impl Element { impl Element {
pub fn TagName(&self) -> DOMString { pub fn TagName(&self) -> DOMString {
str(self.tag_name.to_owned()) str(self.tag_name.to_owned().to_ascii_upper())
} }
pub fn Id(&self) -> DOMString { pub fn Id(&self) -> DOMString {

1
src/test/html/content/test_prototypes.html
View file

@ -3,6 +3,7 @@
<script src="harness.js"></script> <script src="harness.js"></script>
</head> </head>
<body> <body>
<foo-á>foo</foo-á>
<script src="test_prototypes.js"></script> <script src="test_prototypes.js"></script>
</body> </body>
</html> </html>

3
src/test/html/content/test_prototypes.js
View file

@ -4,4 +4,7 @@ is(window.document.documentElement instanceof HTMLElement, true);
is(window.document.documentElement instanceof HTMLHtmlElement, true); is(window.document.documentElement instanceof HTMLHtmlElement, true);
is(window.document instanceof Document, true); is(window.document instanceof Document, true);
is(window.document instanceof HTMLDocument, true); is(window.document instanceof HTMLDocument, true);
is(window.document.documentElement.tagName, "HTML");
is(window.document.getElementsByTagName('foo-á')[0] instanceof HTMLUnknownElement, true);
is(window.document.getElementsByTagName('foo-á')[0].tagName, "FOO-á");
finish(); finish();