From a8c318a0684ec5ff5a40585b657369a46bfb3559 Mon Sep 17 00:00:00 2001 From: Emily McDonough Date: Wed, 6 May 2020 19:35:03 +0000 Subject: [PATCH] style: Use fill length rather than index to indicate a repeat(auto) in subgrid from Servo. Differential Revision: https://phabricator.services.mozilla.com/D70066 --- components/style/values/generics/grid.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/style/values/generics/grid.rs b/components/style/values/generics/grid.rs index 0fbeebea1fb..a0970a6fbc0 100644 --- a/components/style/values/generics/grid.rs +++ b/components/style/values/generics/grid.rs @@ -714,7 +714,7 @@ impl Parse for LineNameList { line_names.truncate(MAX_GRID_LINE as usize); } - let (fill_start, fill_len) = fill_data.unwrap_or((usize::MAX, 0)); + let (fill_start, fill_len) = fill_data.unwrap_or((0, 0)); Ok(LineNameList { names: line_names.into(), @@ -733,7 +733,7 @@ impl ToCss for LineNameList { let fill_start = self.fill_start; let fill_len = self.fill_len; for (i, names) in self.names.iter().enumerate() { - if i == fill_start { + if fill_len > 0 && i == fill_start { dest.write_str(" repeat(auto-fill,")?; } @@ -748,7 +748,7 @@ impl ToCss for LineNameList { } dest.write_str("]")?; - if i == fill_start + fill_len - 1 { + if fill_len > 0 && i == fill_start + fill_len - 1 { dest.write_str(")")?; } }