Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-10-14 15:30:27 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Serialize NaN and infinity angles as per spec

Browse source 
`NaN`, `infinity`, and `-infinity` angles should be specially serialized.

Also fixed a few relevant WPT tests which did not follow spec.
(see https://github.com/web-platform-tests/wpt/pull/38825)

Adjusted WPT test expectations, 40 newly pass 🎉

Differential Revision: https://phabricator.services.mozilla.com/D171658
This commit is contained in:
CanadaHonk 2023-03-07 00:02:55 +00:00 • committed by Martin Robinson
parent 7b28572309
commit a8fef9d4f2
3 changed files with 66 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

33
components/style/values/mod.rs
View file

@ -92,6 +92,39 @@ where
serialize_name(&ident, dest)
}
fn nan_inf_enabled() -> bool {
static_prefs::pref!("layout.css.nan-inf.enabled")
}
/// Serialize a specified dimension with unit, calc, and NaN/infinity handling (if enabled)
pub fn serialize_specified_dimension<W>(v: f32, unit: &str, was_calc: bool, dest: &mut CssWriter<W>) -> fmt::Result
where
W: Write,
{
if was_calc {
dest.write_str("calc(")?;
}
if !v.is_finite() && nan_inf_enabled() {
if v.is_nan() {
dest.write_str("NaN * 1")?;
} else if v == f32::INFINITY {
dest.write_str("infinity * 1")?;
} else if v == f32::NEG_INFINITY {
dest.write_str("-infinity * 1")?;
}
} else {
v.to_css(dest)?;
}
dest.write_str(unit)?;
if was_calc {
dest.write_char(')')?;
}
Ok(())
}
/// A CSS string stored as an `Atom`.
#[repr(transparent)]
#[derive(