Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make traverse_preorder follow children of shadow hosts (#35276)

Browse source 
* Make traverse_preorder follow children of shadow hosts

Children of shadow hosts are not displayed, but they
still exist in the DOM and must be traversed.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Fix traverse_preorder over shadow roots

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

* Update WPT expectations

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

---------

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This commit is contained in:
Simon Wülker 2025-02-04 21:47:33 +01:00 • committed by GitHub
parent 3a75e1205b
commit aa09e2b88f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
17 changed files with 25 additions and 185 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/node.rs
View file

@ -1778,6 +1778,14 @@ impl TreeIterator {
self.current = Some(next_sibling);
return Some(current);
}
if let Some(shadow_root) = ancestor.downcast::<ShadowRoot>() {
// Shadow roots don't have sibling, so after we're done traversing
// one we jump to the first child of the host
if let Some(child) = shadow_root.Host().upcast::<Node>().GetFirstChild() {
self.current = Some(child);
return Some(current);
}
}
self.depth -= 1;
}
debug_assert_eq!(self.depth, 0);
@ -1801,8 +1809,6 @@ impl Iterator for TreeIterator {
self.current = Some(DomRoot::from_ref(shadow_root.upcast::<Node>()));
self.depth += 1;
return Some(current);
} else {
return self.next_skipping_children_impl(current);
}
}
}