Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-13 17:35:36 +01:00
Code Issues Projects Releases Packages Wiki Activity

Implements HTMLDialogElement#close

Browse source
This commit is contained in:
clstl 2016-08-13 16:17:03 +03:00
parent d29f61af31
commit aa5edd1118
5 changed files with 30 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tests/wpt/metadata/html/dom/interfaces.html.ini
View file

@ -4374,9 +4374,6 @@
[HTMLDialogElement interface: operation showModal([object Object\],[object Object\])]
expected: FAIL
[HTMLDialogElement interface: operation close(DOMString)]
expected: FAIL
[HTMLScriptElement interface: attribute async]
expected: FAIL

12
tests/wpt/metadata/html/semantics/interactive-elements/the-dialog-element/dialog-close.html.ini
View file

@ -1,17 +1,5 @@
[dialog-close.html]
type: testharness
[close() fires a close event]
expected: FAIL
[close() on a <dialog> that doesn't have an open attribute throws an InvalidStateError exception]
expected: FAIL
[close() removes the open attribute and set the returnValue to the first argument]
expected: FAIL
[close() without argument removes the open attribute and there's no returnValue]
expected: FAIL
[close() should set the returnValue IDL attribute but not the JS property]
expected: FAIL

7
tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close.html
View file

@ -36,10 +36,9 @@
was_queued = false;
test(function(){
assert_throws("INVALID_STATE_ERR", function() {
d1.close();
});
}, "close() on a <dialog> that doesn't have an open attribute throws an InvalidStateError exception");
d1.close("closedialog");
assert_equals(d1.returnValue, "");
}, "close() on a <dialog> that doesn't have an open attribute aborts the steps");
test(function(){
assert_true(d2.open);