mirror of
https://github.com/servo/servo.git
synced 2025-08-05 21:50:18 +01:00
Auto merge of #23711 - saschanaz:frompoint, r=Manishearth
Implement DOMPoint.fromPoint <!-- Please describe your changes on the following line: --> Implements DOMPoint.fromPoint and fixes codegen to use default value when an optional dictionary member got `undefined`. PS: The codegen change is about: ```webidl dictionary MyDictionary { optional short myMember = 0; short anotherMember; } [Exposed=Window, Constructor] interface MyInterface { void myMethod(optional MyDictionary myDict); }; ``` ```js // The following two must behave same new MyInterface().myMethod({ myMember: undefined, anotherMember = 0 }); new MyInterface().myMethod({ anotherMember = 0 }); ``` --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #23710 <!-- Either: --> - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23711) <!-- Reviewable:end -->
This commit is contained in:
commit
aa752e4d45
19 changed files with 30 additions and 133 deletions
|
@ -6414,7 +6414,8 @@ class CGDictionary(CGThing):
|
|||
conversion = (
|
||||
"{\n"
|
||||
" rooted!(in(cx) let mut rval = UndefinedValue());\n"
|
||||
" if r#try!(get_dictionary_property(cx, object.handle(), \"%s\", rval.handle_mut())) {\n"
|
||||
" if r#try!(get_dictionary_property(cx, object.handle(), \"%s\", rval.handle_mut()))"
|
||||
" && !rval.is_undefined() {\n"
|
||||
"%s\n"
|
||||
" } else {\n"
|
||||
"%s\n"
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue