Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #21933 - notriddle:navigation-redirect-status-code, r=nox

Browse source 
Thread the status through navigation redirects

This is necessary because status codes affect whether the redirect is done with the same HTTP method or a different one.

This is part of #21886, but there's also a flaw in how iframes are handled that is causing the redirect to take over the entire window, so this commit doesn't entirely fix slither.io.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes are part of #21886, but more changes are needed to actually fix it

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21933)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2018-10-16 09:21:22 -04:00 • committed by GitHub
commit aa9591137a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 57 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/wpt/web-platform-tests/fetch/redirect-navigate/302-found-post-handler.py Normal file
View file

@ -0,0 +1,13 @@
def main(request, response):
if request.method == "POST":
response.add_required_headers = False
response.writer.write_status(302)
response.writer.write_header("Location", request.url)
response.writer.end_headers()
response.writer.write("")
elif request.method == "GET":
return ([("Content-Type", "text/plain")],
"OK")
else:
return ([("Content-Type", "text/plain")],
"FAIL")

20
tests/wpt/web-platform-tests/fetch/redirect-navigate/302-found-post.html Normal file
View file

@ -0,0 +1,20 @@
<!DOCTYPE html>
<!-- Step 1: send POST request to a URL which will then 302 Found redirect -->
<title>HTTP 302 Found POST Navigation Test</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
async_test(function(t) {
window.addEventListener("load", function() {
var frame = document.getElementById("frame");
var link = new URL("302-found-post-handler.py", window.location.href);
frame.contentWindow.document.body.innerHTML = '<form action="' + link.href + '" method="POST" id="form"><input name="n"></form>';
frame.contentWindow.document.getElementById("form").submit();
frame.addEventListener("load", t.step_func_done(function() {
assert_equals(frame.contentWindow.document.body.textContent, "OK");
}));
});
}, "HTTP 302 Found POST Navigation");
</script>
<body>
<iframe id="frame" src="about:blank"></iframe>