From aad5b23e2ba432fd9674f0560e50b3ac5abb2fd5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fernando=20Jim=C3=A9nez=20Moreno?= <ferjmoreno@gmail.com>
Date: Thu, 18 Apr 2019 11:50:09 +0200
Subject: [PATCH] Use input instead of change for volume control

---
 resources/media_controls.js | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/resources/media_controls.js b/resources/media_controls.js
index 25489fbec22..855e9774096 100644
--- a/resources/media_controls.js
+++ b/resources/media_controls.js
@@ -160,7 +160,7 @@
       this.controlEvents = [
         { el: this.elements.playPauseButton, type: "click"},
         { el: this.elements.volumeSwitch, type: "click" },
-        { el: this.elements.volumeLevel, type: "change" },
+        { el: this.elements.volumeLevel, type: "input" },
       ];
       this.controlEvents.forEach(({ el, type }) => {
         el.addEventListener(type, this);
@@ -269,10 +269,10 @@
               break;
           }
           break;
-        case "change":
+        case "input":
           switch (event.currentTarget) {
             case this.elements.volumeLevel:
-              this.render();
+              this.changeVolume();
               break;
           }
           break;
@@ -322,6 +322,13 @@
     muteUnmute() {
       this.media.muted = !this.media.muted;
     }
+
+    changeVolume() {
+      const volume = parseInt(this.elements.volumeLevel.value);
+      if (!isNaN(volume)) {
+        this.media.volume = volume / 100;
+      }
+    }
   }
 
   new MediaControls();