Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-11 10:00:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Automatically verify that derive() lists are alphabetically ordered

Browse source
This commit is contained in:
Clément DAVID 2017-08-21 22:56:05 +02:00
parent 16c1446137
commit ab73f3d61d
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
python/tidy/servo_tidy/tidy.py
View file

@ -691,6 +691,19 @@ def check_rust(file_name, lines):
# we now erase previous entries
prev_mod = {}
# derivable traits should be alphabetically ordered
if is_attribute:
# match the derivable traits filtering out macro expansions
match = re.search(r"#\[derive\(([a-zA-Z, ]*)", line)
if match:
derives = map(lambda w: w.strip(), match.group(1).split(','))
# sort, compare and report
sorted_derives = sorted(derives)
if sorted_derives != derives:
yield(idx + 1, decl_message.format("derivable traits list")
+ decl_expected.format(", ".join(sorted_derives))
+ decl_found.format(", ".join(derives)))
# Avoid flagging <Item=Foo> constructs
def is_associated_type(match, line):